From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52B64C433DB for ; Wed, 3 Feb 2021 15:50:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F351664F5D for ; Wed, 3 Feb 2021 15:50:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234532AbhBCPuA (ORCPT ); Wed, 3 Feb 2021 10:50:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234637AbhBCPn0 (ORCPT ); Wed, 3 Feb 2021 10:43:26 -0500 Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4209BC06178B for ; Wed, 3 Feb 2021 07:42:46 -0800 (PST) Received: by mail-qt1-x833.google.com with SMTP id l23so17797093qtq.13 for ; Wed, 03 Feb 2021 07:42:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ihoLZcZRyoEW0VgthAIYy/Wrfm42/ApXno9WsQqxkNU=; b=EoLZC0YrqtaMnD9fFHdOTe28Sq/Oq9SXXrQvYof6S3pgN8mPpoysrzaICfVrAWKMFZ dYTQFH07BnbrYxiv1+GgFXaJbTOwGZNRTohTHUC+19KCN5exgL/Jv/MNZCrrg9oMMuzx w674xHO/fY+x4ZFP1JWOyGdUgSlVOu+DCOLM5fFXvvX7UlBe6Il55wlTos8uZHsHsMdg 9KsAQfSFXg6R6lMQSYLhU5RNkOia8sD3Nk3R0KhwD6f/L6exZ3TqtbNZN9VLbmdHajgN ExNb/1MH7mgrolJuYEQrZUOZ5l3jW00/n77Ezron+rfwlrId2v5OxB9ojU+rB2cr1MoK CB3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ihoLZcZRyoEW0VgthAIYy/Wrfm42/ApXno9WsQqxkNU=; b=QbhBtsaqAju1jX6SuXKIvlOfeqPXjJtS3OpjYDCfi83wqrkgGnMrPLDhvXEM7BUDyA yWz+/TXnHFsXefNfK6mWA3PTnKBbcUpHjJN0+/G7i7nKJJdpkDsuh2boxi6VM+PHYIlm Y5CUF7DhhWQGTWVpkc1qTxDk9F7hPQ4lsie8jas/fVDffQopID7VE9ngc7BPvPjwqC2Q lf19SD6c7zT0HGosr9/PWo7fSj83Hrv4BGPWVxIaW/0xhV5H4W88Fr81pxVuO6tsVNOZ /taj07Ycb3TaNs4Q2XqfWqXOKef9NuP16gWnssF5wfzZrAkpRF8PvLoDmRLct5zGtPHE EM8w== X-Gm-Message-State: AOAM531mrVyE9Oebd0C6resKFIEuJJ79ddJMTk2XOaYkQOHrljxiIuy+ 7cdEV2YkBM/3+NXloB35mIoe16LHqZ0keMsjIwC9PQ== X-Google-Smtp-Source: ABdhPJx9j8LPPgRdIBOzrJip12wYThmZ7w8kPmoBmUPYnNAGBqHDdVBR/Q48vevfvHS/9OhLwOItlwZqDHNvm95GqUc= X-Received: by 2002:ac8:1009:: with SMTP id z9mr2954958qti.347.1612366965030; Wed, 03 Feb 2021 07:42:45 -0800 (PST) MIME-Version: 1.0 References: <20210202161733.932215-1-kyletso@google.com> <20210202161733.932215-2-kyletso@google.com> <20210203124724.GD1687065@kuha.fi.intel.com> <20210203145143.GA58095@roeck-us.net> <20210203150121.GI1687065@kuha.fi.intel.com> <20210203150419.GJ1687065@kuha.fi.intel.com> In-Reply-To: <20210203150419.GJ1687065@kuha.fi.intel.com> From: Kyle Tso Date: Wed, 3 Feb 2021 23:42:28 +0800 Message-ID: Subject: Re: [PATCH v5 1/8] usb: typec: Manage SVDM version To: Heikki Krogerus Cc: Guenter Roeck , Greg KH , Hans de Goede , robh+dt@kernel.org, Badhri Jagan Sridharan , USB , LKML , devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank you Heikki and Guenter for these valuable reviews. I will update it in the next version. thanks, Kyle On Wed, Feb 3, 2021 at 11:04 PM Heikki Krogerus wrote: > > On Wed, Feb 03, 2021 at 05:01:26PM +0200, Heikki Krogerus wrote: > > On Wed, Feb 03, 2021 at 06:51:43AM -0800, Guenter Roeck wrote: > > > Thinking about it, would it make make sense to define the functions as > > > static inline ? > > > > I (and I believe Guenter too) > > s/I believe Guenter too/I thought you too/ > > > want to keep these structures protected > > for now. If the API starts to get too bloated, then I guess I have to > > reconsider that. But I don't think we are there yet. > > > > I have been thinking about moving the USB PD negotiation details to a > > separate structure that could be more accessible for everybody. That > > should allow me continue to protect my precious structures. But I have > > not yet put much though into that. > > > -- > heikki