From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E2EAC433E6 for ; Wed, 23 Dec 2020 14:41:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FEB92332A for ; Wed, 23 Dec 2020 14:41:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727990AbgLWOls (ORCPT ); Wed, 23 Dec 2020 09:41:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725957AbgLWOlr (ORCPT ); Wed, 23 Dec 2020 09:41:47 -0500 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3332CC0613D3 for ; Wed, 23 Dec 2020 06:41:07 -0800 (PST) Received: by mail-qk1-x733.google.com with SMTP id w79so15050916qkb.5 for ; Wed, 23 Dec 2020 06:41:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TyB5HqZGghDqQHiswidE0Nhl7bc1fz9iuEH17F6HS7o=; b=IgDeBDPev8DvZ4oaMbBRJxjg1MAgyoPY7166NixyJvkYllxi7/p5kshNjanc9HtTq6 sYiKXh7tNOVrkLuVBGcKEwm5x7HBcJsdcxs5yXmSJyLaVXBrqnZ9nLmMk7GaKy9goTgx AsV9Hjpq8Z4uM9zAfHPPwRUlc3zf5y6KvcWo1x4h/zhdryrGq3ClbRppdJBFaPuehdMn I8NwLTQ2quDHkqPvXp39O8XGx7SjzKTG0cka0nGhJtO8WW0ExIYDTsZM+C76kia1TXrP bYLX6d2SVIqaA0WSilV717axihAAEID9HoAiC3RvsVA5+4SOMjcT4T8On5QRvtCI+non QMjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TyB5HqZGghDqQHiswidE0Nhl7bc1fz9iuEH17F6HS7o=; b=ikxzNlQ7dhcSA8x+u7UOgDTdu09cEh357NT5d/qkvw8vGIoPLpfVMMEBgGk4zDL2Uw MXKoxuiv0x159nwbeXHCcbL2fw7iEdkXN4aWGRQ3RbP7AaxV+KFgMZlv7B0jCyHk81xH 32vLC4p5lHLo2MPV2byAxEB53sbjTXmUWr9KxrZs2Qoyg1uyNKet7HyVpK8F5uSq2iKN 5ABqv3eaXGQuh71C8q9yi8JMpaL6GiFVSzteKKMD7mA9JOJwnzPKIKP4Dh+sncBlOlEj NlcKG32ZFNSDu34m/PS1pgoPh3tlfmfScFuhqh7lGr7Ggb9O+X8ClifanjoL2SQc9dSf f8Ng== X-Gm-Message-State: AOAM531sjTdhNLmPU7xjbLEnV0flQ/UBgp+XUfn6mr3+RlriDXdCE+sN L4rl25hyUk/nLLrQp9zAjg5rcYHIupXp2GPYfRUYfg== X-Google-Smtp-Source: ABdhPJysJd2t4COKogdQKzy4ot2WGRAvIzKHkmy7YpYmNbYXSk3vLuWgyIr4YuTWsYV57jPoX5GeEx2ZBduATggTEBs= X-Received: by 2002:a37:a747:: with SMTP id q68mr27163288qke.352.1608734466216; Wed, 23 Dec 2020 06:41:06 -0800 (PST) MIME-Version: 1.0 References: <7f2e171f-fa44-ef96-6cc6-14e615e3e457@codeaurora.org> <601d4b1a-8526-f7ad-d0f3-305894682109@codeaurora.org> <9e0d2c07-af1f-a1d3-fb0d-dbf2ae669f96@codeaurora.org> <48df48fe-dc36-83a4-1c11-e9d0cf230372@codeaurora.org> <6110a26b-dc87-b6f9-e679-aa60917403de@codeaurora.org> In-Reply-To: From: Alexander Potapenko Date: Wed, 23 Dec 2020 15:40:54 +0100 Message-ID: Subject: Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE To: Vijayanand Jitta Cc: Minchan Kim , Vincenzo Frascino , dan.j.williams@intel.com, broonie@kernel.org, Masami Hiramatsu , LKML , Andrew Morton , Andrey Konovalov , qcai@redhat.com, ylal@codeaurora.org, vinmenon@codeaurora.org, kasan-dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Michan, We would still need config option so that we can reduce the > memory consumption on low ram devices using config. > > Alex, On this, > "I also suppose device vendors may prefer setting a fixed (maybe > non-default) hash size for low-memory devices rather than letting the > admins increase it." > I see kernel param swiotlb does similar thing i.e; '0' to disable and > set a value to configure size. > > I am fine with either of the approaches, > > 1. I can split this patch into two > i) A bool variable to enable/disable stack depot. > ii) A config for the size. I still believe this is a more appropriate solution. Thanks in advance!