From: Alexander Potapenko <glider@google.com>
To: Vijayanand Jitta <vjitta@codeaurora.org>
Cc: Minchan Kim <minchan@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
dan.j.williams@intel.com, broonie@kernel.org,
Masami Hiramatsu <mhiramat@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andrey Konovalov <andreyknvl@google.com>,
qcai@redhat.com, ylal@codeaurora.org, vinmenon@codeaurora.org
Subject: Re: [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE
Date: Wed, 16 Dec 2020 14:34:36 +0100 [thread overview]
Message-ID: <CAG_fn=V8e8y1fbOaYUD5SfDSQ9+Tc3r7w6ZSoJ-ZNFJvvq-Aeg@mail.gmail.com> (raw)
In-Reply-To: <601d4b1a-8526-f7ad-d0f3-305894682109@codeaurora.org>
> > To reiterate, I think you don't need a tunable stack_hash_order
> > parameter if the only use case is to disable the stack depot.
> > Maybe it is enough to just add a boolean flag?
>
> There are multiple users of stackdepot they might still want to use
> stack depot but with a lower memory footprint instead of MAX_SIZE
> so, a configurable size might help here ?
Can you provide an example of a use case in which the user wants to
use the stack depot of a smaller size without disabling it completely,
and that size cannot be configured statically?
As far as I understand, for the page owner example you gave it's
sufficient to provide a switch that can disable the stack depot if
page_owner=off.
> > Or even go further and disable the stack depot in the same place that
> > disables page owner, as the user probably doesn't want to set two
> > flags instead of one?
> >
>
> Since, page owner is not the only user of stack depot we can't take that
> decision of disabling stack depot if page owner is disabled.
Agreed, but if multiple subsystems want to use stackdepot together, it
is even harder to estimate the total memory consumption.
How likely is it that none of them will need MAX_SIZE?
> >> Minchan,
> >> This should be fine right ? Do you see any issue with disabling
> >> stack depot completely ?
> >>
> >> Thanks,
> >> Vijay
> >>
> >>>> Thanks,
> >>>> Vijay
> >>>>
> >>>>>>> Thanks,
> >>>>>>> Vijay
> >>>>>>>
> >>>>>>>>> Thanks,
> >>>>>>>>> Vijay
> >>>>>>>>>
> >>>>>>>>> --
> >>>>>>>>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
> >>>>>>>>> member of Code Aurora Forum, hosted by The Linux Foundation
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>> --
> >>>>>>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
> >>>>>>> member of Code Aurora Forum, hosted by The Linux Foundation
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>
> >>>>
> >>>> --
> >>>> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
> >>>> member of Code Aurora Forum, hosted by The Linux Foundation
> >>>
> >>>
> >>>
> >>
> >> --
> >> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
> >> member of Code Aurora Forum, hosted by The Linux Foundation
> >
> >
> >
>
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
> member of Code Aurora Forum, hosted by The Linux Foundation
--
Alexander Potapenko
Software Engineer
Google Germany GmbH
Erika-Mann-Straße, 33
80636 München
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
next prev parent reply other threads:[~2020-12-16 13:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 5:00 [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE vjitta
2020-12-11 8:36 ` Alexander Potapenko
2020-12-11 12:45 ` Vijayanand Jitta
2020-12-11 13:25 ` Alexander Potapenko
2020-12-14 4:02 ` Vijayanand Jitta
2020-12-14 9:34 ` Alexander Potapenko
2020-12-14 10:32 ` Vijayanand Jitta
2020-12-16 3:43 ` Vijayanand Jitta
2020-12-16 8:26 ` Alexander Potapenko
2020-12-16 13:06 ` Vijayanand Jitta
2020-12-16 13:11 ` Alexander Potapenko
2020-12-16 13:22 ` Vijayanand Jitta
2020-12-16 13:34 ` Alexander Potapenko [this message]
2020-12-17 5:38 ` Vijayanand Jitta
2020-12-17 10:19 ` Dmitry Vyukov
2020-12-17 10:54 ` Alexander Potapenko
2020-12-18 8:40 ` Vijayanand Jitta
2020-12-21 11:14 ` Vijayanand Jitta
2020-12-21 15:04 ` Alexander Potapenko
2020-12-21 20:29 ` Minchan Kim
2020-12-22 5:55 ` Vijayanand Jitta
2020-12-23 14:40 ` Alexander Potapenko
2020-12-28 4:51 ` Vijayanand Jitta
2020-12-15 9:34 ` [lib] 1333d0ba67: WARNING:at_kernel/locking/lockdep.c:#lockdep_register_key kernel test robot
2020-12-17 10:25 ` [PATCH v3] lib: stackdepot: Add support to configure STACK_HASH_SIZE Dmitry Vyukov
2020-12-17 10:27 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG_fn=V8e8y1fbOaYUD5SfDSQ9+Tc3r7w6ZSoJ-ZNFJvvq-Aeg@mail.gmail.com' \
--to=glider@google.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=minchan@kernel.org \
--cc=qcai@redhat.com \
--cc=vincenzo.frascino@arm.com \
--cc=vinmenon@codeaurora.org \
--cc=vjitta@codeaurora.org \
--cc=ylal@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).