From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D4D9C5517A for ; Wed, 11 Nov 2020 14:20:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED76520756 for ; Wed, 11 Nov 2020 14:20:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="GFal+cQo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726588AbgKKOUX (ORCPT ); Wed, 11 Nov 2020 09:20:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbgKKOUU (ORCPT ); Wed, 11 Nov 2020 09:20:20 -0500 Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9254BC0613D1 for ; Wed, 11 Nov 2020 06:20:19 -0800 (PST) Received: by mail-qt1-x844.google.com with SMTP id p12so1341667qtp.7 for ; Wed, 11 Nov 2020 06:20:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=JMEn4lYfqSDEvjbMdtc4A2bwMj+MmSPwjJgTPuD5gJo=; b=GFal+cQow0Qjk5lNhjw8e+r2OEerm1rZ9j6xJQ6wLclouuxb32+yaI/XHplYRS2V/L o+TghGBtQXi5k/Te+e3rvhVWgytv+U/4tkc/Z6ZQuFY45OBj1UNNOOpEbJKXTX8Yq4PE 3+444ZuKPGJVPlEV3yaGkep9xaLi7U38YlIV7dIa79529Ei7sZGU+D0+ZomW4D0A91Qc lP47MamAEwOHaE65rE4mOUBEGPhhESSdKEoYcQhL3yk8ZI1a2NnP5CEOfwk7XOLA0PtT LnBvtjbcQA67qM9eMkJ+r2+/txTneMeeRHBoJ4wt0QreqSWgO/Kszjw4hCaNmhTATxMJ 7tLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JMEn4lYfqSDEvjbMdtc4A2bwMj+MmSPwjJgTPuD5gJo=; b=JY17u1u49WOBDgeTqZIzB9qH6DLbnh9ET2l7A+lb2QcvRJP9Zs7T1fds7v8rZSAzQc +Myi+dUsAVwU9eKlHM43TWuen7PiR0FNmEQ9MCyq7ei0CafFm4E1NhLQg/aQ3ZJ/Luw0 hm/xaVy+dJo4xK+eweSoC4smFk+Er/+9myQBW+bVvVz7E3He7XU0wTMmqAEdCQZ2CS/h 1eZM43cvOIE0bBp/vaSyGmJLRB4VAi8KfZMlZJSXDJjcn5CBY2PF78tHJjLBgPL3jR3/ dWVDQhE2dJnefASFWlY3jDPps1tvEv6cUy3PPcmNfhZxtQnExqe6KS5ATiJ3up5ixtYW kSJA== X-Gm-Message-State: AOAM532YrSEyDJ5fHXjEySVnHbfxqBupyGvoDx7eUD71pZNPo/Yx26G7 da878T00aVhgQReaw+qaZt5gznGGa781YK0DxmHSTw== X-Google-Smtp-Source: ABdhPJxsl2FT8v0gKKSfiyzq0nZ+AM/YBVaPtxAlOvp8/Vl46KzKhLZ8b9e2SozNu96fbbuuensy8LjfPhdlu9XC6yk= X-Received: by 2002:ac8:5c85:: with SMTP id r5mr18883719qta.8.1605104418550; Wed, 11 Nov 2020 06:20:18 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Wed, 11 Nov 2020 15:20:07 +0100 Message-ID: Subject: Re: [PATCH v9 12/44] kasan: don't duplicate config dependencies To: Andrey Konovalov Cc: Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , Andrew Morton , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 11:11 PM Andrey Konovalov w= rote: > > Both KASAN_GENERIC and KASAN_SW_TAGS have common dependencies, move > those to KASAN. > > Signed-off-by: Andrey Konovalov > Signed-off-by: Vincenzo Frascino > Reviewed-by: Marco Elver Reviewed-by: Alexander Potapenko > --- > Change-Id: I77e475802e8f1750b9154fe4a6e6da4456054fcd > --- > lib/Kconfig.kasan | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan > index 8f0742a0f23e..ec59a0e26d09 100644 > --- a/lib/Kconfig.kasan > +++ b/lib/Kconfig.kasan > @@ -24,6 +24,8 @@ menuconfig KASAN > (HAVE_ARCH_KASAN_SW_TAGS && CC_HAS_KASAN_SW_TAGS) > depends on (SLUB && SYSFS) || (SLAB && !DEBUG_SLAB) > depends on CC_HAS_WORKING_NOSANITIZE_ADDRESS > + select CONSTRUCTORS > + select STACKDEPOT > help > Enables KASAN (KernelAddressSANitizer) - runtime memory debugge= r, > designed to find out-of-bounds accesses and use-after-free bugs= . > @@ -46,10 +48,7 @@ choice > config KASAN_GENERIC > bool "Generic mode" > depends on HAVE_ARCH_KASAN && CC_HAS_KASAN_GENERIC > - depends on (SLUB && SYSFS) || (SLAB && !DEBUG_SLAB) > select SLUB_DEBUG if SLUB > - select CONSTRUCTORS > - select STACKDEPOT > help > Enables generic KASAN mode. > > @@ -70,10 +69,7 @@ config KASAN_GENERIC > config KASAN_SW_TAGS > bool "Software tag-based mode" > depends on HAVE_ARCH_KASAN_SW_TAGS && CC_HAS_KASAN_SW_TAGS > - depends on (SLUB && SYSFS) || (SLAB && !DEBUG_SLAB) > select SLUB_DEBUG if SLUB > - select CONSTRUCTORS > - select STACKDEPOT > help > Enables software tag-based KASAN mode. > > -- > 2.29.2.222.g5d2a92d10f8-goog > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg