From: Kevin Hilman <khilman@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Robin Holt <holt@sgi.com>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Russ Anderson <rja@sgi.com>, "H. Peter Anvin" <hpa@zytor.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
Arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -v11 resend 10/11] arm, change reboot_mode to use enum reboot_mode
Date: Thu, 27 Jun 2013 14:39:48 -0700 [thread overview]
Message-ID: <CAGa+x85zxXEEYBC6569+48xjfO4VoDB0q4NSbVaj2JbWuEJRCQ@mail.gmail.com> (raw)
In-Reply-To: <CAGa+x85UP6_3n-m76w_NHMF5Ld-rEu+ufSbRbAE4RhdU7GuKnw@mail.gmail.com>
On Thu, Jun 27, 2013 at 2:28 PM, Kevin Hilman <khilman@linaro.org> wrote:
> On Tue, Jun 25, 2013 at 2:41 PM, Kevin Hilman <khilman@linaro.org> wrote:
>> On Wed, Jun 19, 2013 at 11:16 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>> On Wednesday 19 June 2013, Andrew Morton wrote:
>>>> This patchset gets a lot of rejects which I keep on fixing up. Please
>>>> merge up early in the merge window and compile-test (and review) the
>>>> linux-next changes to make sure I didn't muck up the reject-fixing,
>>>> then we should be fine.
>>>
>>> Ok, good. The patch below is what I used locally to get everything to
>>> build. Please fold that into the larger patch.
>>
>> I'm still seeing build breaks in linux-next due to the original patch.
>>
>> Will the fix below from Arnd be folded into the original?
>
> Actually, there's even more ARM build fallout from this patch not
> covered by Arnd's fix. For example, building the ixp4xx_defconfig now
> has an include nesting mess[1] that is not a trivial fixup (at least
> that I have found yet).
>
> IMO, this patch needs to be dropped from -next until it gets better
> build coverage testing on ARM.
OK, the change below also needs to be folded in to fix ixp4xxx_defconfig on ARM.
Kevin
diff --git a/arch/arm/mach-ixp4xx/include/mach/platform.h
b/arch/arm/mach-ixp4xx/include/mach/platform.h
index 4c4c6a6..8f81a5b 100644
--- a/arch/arm/mach-ixp4xx/include/mach/platform.h
+++ b/arch/arm/mach-ixp4xx/include/mach/platform.h
@@ -13,7 +13,7 @@
#ifndef __ASSEMBLY__
-#include <linux/reboot.h>
+extern enum reboot_mode reboot_mode;
#include <asm/types.h>
next prev parent reply other threads:[~2013-06-27 21:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-06 11:47 [PATCH -v11 resend 00/11] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
2013-06-06 11:47 ` [PATCH -v11 resend 01/11] CPU hotplug: Provide a generic helper to disable/enable CPU hotplug Robin Holt
2013-06-06 11:47 ` [PATCH -v11 resend 02/11] Migrate shutdown/reboot to boot cpu Robin Holt
2013-06-06 11:47 ` [PATCH -v11 resend 03/11] Remove -stable friendly PF_THREAD_BOUND define Robin Holt
2013-06-06 11:47 ` [PATCH -v11 resend 04/11] Move shutdown/reboot related functions to kernel/reboot.c Robin Holt
2013-06-06 11:47 ` [PATCH -v11 resend 05/11] checkpatch.pl the new kernel/reboot.c file Robin Holt
2013-06-06 11:47 ` [PATCH -v11 resend 06/11] x86, prepare reboot_mode for moving to generic kernel code Robin Holt
2013-06-06 11:47 ` [PATCH -v11 resend 07/11] unicore32, " Robin Holt
2013-06-06 11:47 ` [PATCH -v11 resend 08/11] arm, Remove unused restart_mode fields from some arm subarchs Robin Holt
2013-06-06 11:47 ` [PATCH -v11 resend 09/11] arm, prepare reboot_mode for moving to generic kernel code Robin Holt
2013-06-06 11:47 ` [PATCH -v11 resend 10/11] arm, change reboot_mode to use enum reboot_mode Robin Holt
2013-06-10 22:11 ` Andrew Morton
2013-06-19 10:58 ` Arnd Bergmann
2013-06-19 13:52 ` Arnd Bergmann
2013-06-19 17:21 ` Andrew Morton
2013-06-19 18:16 ` Arnd Bergmann
2013-06-25 21:41 ` Kevin Hilman
2013-06-27 21:28 ` Kevin Hilman
2013-06-27 21:39 ` Kevin Hilman [this message]
2013-06-06 11:47 ` [PATCH -v11 resend 11/11] Move arch/x86 reboot= handling to generic kernel Robin Holt
-- strict thread matches above, loose matches on Subject: below --
2013-05-16 16:14 [PATCH -v11 resend 00/11] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
2013-05-16 16:14 ` [PATCH -v11 resend 10/11] arm, change reboot_mode to use enum reboot_mode Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGa+x85zxXEEYBC6569+48xjfO4VoDB0q4NSbVaj2JbWuEJRCQ@mail.gmail.com \
--to=khilman@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=gxt@mprc.pku.edu.cn \
--cc=holt@sgi.com \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rja@sgi.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).