From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752005AbdHDCYZ (ORCPT ); Thu, 3 Aug 2017 22:24:25 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:36010 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751891AbdHDCYX (ORCPT ); Thu, 3 Aug 2017 22:24:23 -0400 MIME-Version: 1.0 In-Reply-To: <20170801145416.61854-1-icenowy@aosc.io> References: <20170801145416.61854-1-icenowy@aosc.io> From: Chen-Yu Tsai Date: Fri, 4 Aug 2017 10:23:59 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH] pinctrl: sunxi: fix V3s pinctrl driver IRQ bank base To: Icenowy Zheng Cc: Maxime Ripard , Chen-Yu Tsai , Linus Walleij , linux-arm-kernel , "linux-gpio@vger.kernel.org" , linux-kernel , linux-sunxi , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 1, 2017 at 10:54 PM, Icenowy Zheng wrote: > The V3s pin controller doesn't have the bank 0 (starts at address > 0x200), which is like A33. However, this is not workarounded when was not worked around "Work around" is a verb phrase. "Workaround" is a noun. > developing the driver, which makes IRQ not working. broke the IRQs. > > Fix the IRQ bank base. > > Fixes: 56d9e4a76039 ("pinctrl: sunxi: add driver for V3s SoC") > Cc: stable@vger.kernel.org > Signed-off-by: Icenowy Zheng Confirmed this is the same thing we saw on A33. The fix is the same. Apart from the typo / grammar errors above, Reviewed-by: Chen-Yu Tsai