From: Chen-Yu Tsai <wens@csie.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: "Mylène Josserand" <mylene.josserand@free-electrons.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Russell King" <linux@armlinux.org.uk>,
"Chen-Yu Tsai" <wens@csie.org>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
simon.budig@kernelconcepts.de,
linux-kernel <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH 1/5] arm: dts: sun8i: a83t: Add I2C0 node
Date: Mon, 11 Dec 2017 16:31:20 +0800 [thread overview]
Message-ID: <CAGb2v64awf8YwBM-M6GS_dy+6mpT1e5Bzy-zLYNfRmjLGb55bw@mail.gmail.com> (raw)
In-Reply-To: <20171211071513.xgni3t6ihmeeebre@flea.lan>
On Mon, Dec 11, 2017 at 3:15 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi,
>
> On Fri, Dec 08, 2017 at 10:54:15PM +0100, Mylène Josserand wrote:
>> Add I2C0 node for A83T.
>>
>> Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com>
>> ---
>> arch/arm/boot/dts/sun8i-a83t.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
>> index 19acae1b4089..848cf3f19962 100644
>> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
>> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
>> @@ -177,6 +177,17 @@
>> #dma-cells = <1>;
>> };
>>
>> + i2c0: i2c@01c2ac00 {
>
> Drop the leading 0, it generates a warning in dtc.
>
>> + compatible = "allwinner,sun6i-a31-i2c";
>
> Can you add a SoC-specific compatible there please?
>
>> + reg = <0x01c2ac00 0x400>;
>
> And you should order your nodes by physical address.
I have a similar patch in my A83T I2S branch:
https://github.com/wens/linux/commit/8b76a3e555b39a06f3f8182e4ff5645de4c4cbc3
ChenYu
next prev parent reply other threads:[~2017-12-11 8:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 21:54 [PATCH 0/5] sun8i-a83t: Add touchscreen support on TBS A711 Mylène Josserand
2017-12-08 21:54 ` [PATCH 1/5] arm: dts: sun8i: a83t: Add I2C0 node Mylène Josserand
2017-12-11 7:15 ` Maxime Ripard
2017-12-11 8:31 ` Chen-Yu Tsai [this message]
2017-12-08 21:54 ` [PATCH 2/5] arm: dts: sun8i: a83t: Add I2C0 pins group Mylène Josserand
2017-12-08 21:54 ` [PATCH 3/5] arm: dts: sun8i: a83t: a711: Enable I2C0 Mylène Josserand
2017-12-11 7:18 ` Maxime Ripard
2017-12-08 21:54 ` [PATCH 4/5] Input: edt-ft5x06 - Add support for regulator Mylène Josserand
2017-12-09 1:16 ` Dmitry Torokhov
2017-12-09 1:24 ` Dmitry Torokhov
2017-12-08 21:54 ` [PATCH 5/5] arm: dts: sun8i: a83t: a711: Add touchscreen node Mylène Josserand
2017-12-11 7:16 ` Maxime Ripard
2017-12-08 22:01 ` [PATCH 0/5] sun8i-a83t: Add touchscreen support on TBS A711 Mylene JOSSERAND
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v64awf8YwBM-M6GS_dy+6mpT1e5Bzy-zLYNfRmjLGb55bw@mail.gmail.com \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mylene.josserand@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=simon.budig@kernelconcepts.de \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).