From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D2C9C43441 for ; Thu, 15 Nov 2018 16:52:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F31E72089D for ; Thu, 15 Nov 2018 16:52:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F31E72089D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csie.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388561AbeKPDBQ (ORCPT ); Thu, 15 Nov 2018 22:01:16 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:37470 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388088AbeKPDBQ (ORCPT ); Thu, 15 Nov 2018 22:01:16 -0500 Received: by mail-ed1-f68.google.com with SMTP id h15so12506505edb.4; Thu, 15 Nov 2018 08:52:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wL59Bc+U/an42Y1EJzdct5NSSOa8no3V/7b7BCsabow=; b=Ggw0E5vsgH6vZSNfXCEcz2JUZjZpqXbVM4LVp+ujSdk+mU0f71LRSlqGXw8WSbuIzQ MEW5WipbTVtnutGheh33os3EqyrA4WfYomaUCZ3KlvCAADX5V6FLbXBnhfUYA+UjM0qp rp17wPckAwB/OS0YYpNNrvvSt3qxbElUJS0YF6PtAyunfT2BFAGAG066MaTTY1pJpDtu sbifQ8Uw3WdjIebrugY1TXXJjjeNe8NRCopa13k1M6UVJQgSK8UgsjY3NHnjFIQGTZsm abSPQKjzgn72ZJyhBdFU6AacShtQeUnGnisnY2zSpmj+yJyXb0slDkyClOR4CcbMb3id TEjw== X-Gm-Message-State: AGRZ1gKg9vspwtHyFV6+UmIS33945IB5KXZGTvIs1+OAGwrzeK72IhM8 TyIRD1P0ofEf6+AbpgQb6u/OoPM04D0= X-Google-Smtp-Source: AJdET5cRPC8a4nG2SNkycntY29JsLc8jeDoNe5VtZM1M/MoWBPSvlP7yN6EVUTSEqAh1ado8ewJb9g== X-Received: by 2002:a17:906:5d10:: with SMTP id g16-v6mr5958328ejt.212.1542300758713; Thu, 15 Nov 2018 08:52:38 -0800 (PST) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com. [209.85.221.41]) by smtp.gmail.com with ESMTPSA id u33sm1907446edm.88.2018.11.15.08.52.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Nov 2018 08:52:38 -0800 (PST) Received: by mail-wr1-f41.google.com with SMTP id v6so98981wrr.12; Thu, 15 Nov 2018 08:52:38 -0800 (PST) X-Received: by 2002:adf:b608:: with SMTP id f8mr6170436wre.120.1542300757984; Thu, 15 Nov 2018 08:52:37 -0800 (PST) MIME-Version: 1.0 References: <20181115145013.3378-1-paul.kocialkowski@bootlin.com> <20181115145013.3378-8-paul.kocialkowski@bootlin.com> In-Reply-To: <20181115145013.3378-8-paul.kocialkowski@bootlin.com> From: Chen-Yu Tsai Date: Fri, 16 Nov 2018 00:52:28 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 07/15] arm64: dts: allwinner: h5: Add system-control node with SRAM C1 To: Paul Kocialkowski Cc: Linux Media Mailing List , devicetree , linux-kernel , linux-arm-kernel , devel@driverdev.osuosl.org, Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Maxime Ripard , Greg Kroah-Hartman , linux-sunxi@googlegroups.com, Hans Verkuil , Sakari Ailus , Thomas Petazzoni Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 15, 2018 at 10:50 PM Paul Kocialkowski wrote: > > Add the H5-specific system control node description to its device-tree > with support for the SRAM C1 section, that will be used by the video > codec node later on. > > Signed-off-by: Paul Kocialkowski > --- > arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 22 ++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > index b41dc1aab67d..c2d14b22b8c1 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi > @@ -94,6 +94,28 @@ > }; > > soc { > + system-control@1c00000 { > + compatible = "allwinner,sun50i-h5-system-control"; > + reg = <0x01c00000 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + sram_c1: sram@1d00000 { > + compatible = "mmio-sram"; > + reg = <0x01d00000 0x80000>; I'll try to check this one tomorrow. I did find something interesting on the H3: there also seems to be SRAM at 0x01dc0000 to 0x01dcfeff , again mapped by the same bits as SRAM C1. And on the A33, the SRAM C1 range is 0x01d00000 to 0x01d478ff. This was found by mapping the SRAM to the CPU, then using devmem to poke around the register range. If there's SRAM, the first read would typically return random data, and a subsequent write to it would set some value that would be read back correctly. If there's no SRAM, a read either returns 0x0 or some random data that can't be overwritten. You might want to check the other SoCs. ChenYu > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x01d00000 0x80000>; > + > + ve_sram: sram-section@0 { > + compatible = "allwinner,sun50i-h5-sram-c1", > + "allwinner,sun4i-a10-sram-c1"; > + reg = <0x000000 0x80000>; > + }; > + }; > + }; > + > mali: gpu@1e80000 { > compatible = "allwinner,sun50i-h5-mali", "arm,mali-450"; > reg = <0x01e80000 0x30000>; > -- > 2.19.1 >