From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755875AbdAKGo3 (ORCPT ); Wed, 11 Jan 2017 01:44:29 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:36288 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750769AbdAKGo0 (ORCPT ); Wed, 11 Jan 2017 01:44:26 -0500 MIME-Version: 1.0 In-Reply-To: <20170110191514.kgbesffn3xqltnol@lukather> References: <3689701f93c8426bfa476e9a5f31c3642a8a898e.1483980339.git-series.maxime.ripard@free-electrons.com> <20170110191514.kgbesffn3xqltnol@lukather> From: Chen-Yu Tsai Date: Wed, 11 Jan 2017 14:44:00 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 6/6] arm64: allwinner: a64: Increase the MMC max frequency To: Maxime Ripard Cc: Chen-Yu Tsai , Ulf Hansson , Rob Herring , devicetree , linux-arm-kernel , linux-kernel , "linux-mmc@vger.kernel.org" , Andre Przywara Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 3:15 AM, Maxime Ripard wrote: > Hi, > > On Tue, Jan 10, 2017 at 01:01:20AM +0800, Chen-Yu Tsai wrote: >> On Tue, Jan 10, 2017 at 12:46 AM, Maxime Ripard >> wrote: >> > All the controllers can have a maximum frequency of 200MHz. >> > >> > Since older SoCs cannot go that high, we cannot change the default maximum >> > frequency, but fortunately for us we have a property for that in the DT. >> > >> > This also has the side effect of allowing to use the MMC HS200 mode for the >> > boards that support it (with either 1.2v or 1.8v IOs). >> > >> > Signed-off-by: Maxime Ripard >> > --- >> > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 3 +++ >> > 1 file changed, 3 insertions(+), 0 deletions(-) >> > >> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> > index 8e149498e096..f46ae965cf5b 100644 >> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >> > @@ -332,6 +332,7 @@ >> > resets = <&ccu RST_BUS_MMC0>; >> > reset-names = "ahb"; >> > interrupts = ; >> > + max-frequency = <200000000>; >> >> You also have to set one of MMC_CAP2_HS200* in the driver, >> or mmc-hs200-1_8v or mmc-hs200-1_2v in the device tree to >> actually use HS200, right? > > Yes, but that requires a board with 1.8V IOs to work properly, which > not all board use, so it's probably best to enable it in the board > DTS. It's limited by the vqmmc regulator. Either way the host controller supports it right? ChenYu