From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751748AbdFIHtk (ORCPT <rfc822;w@1wt.eu>);
        Fri, 9 Jun 2017 03:49:40 -0400
Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:53724 "EHLO
        smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751717AbdFIHti (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 9 Jun 2017 03:49:38 -0400
MIME-Version: 1.0
In-Reply-To: <20170609062216.26807-8-dannym@scratchpost.org>
References: <20170609062216.26807-1-dannym@scratchpost.org> <20170609062216.26807-8-dannym@scratchpost.org>
From: Chen-Yu Tsai <wens@csie.org>
Date: Fri, 9 Jun 2017 15:48:59 +0800
X-Gmail-Original-Message-ID: <CAGb2v654SNZcGVx9SXVvLfpz2kHchftyeL2sGOgnvj2T9G7KBA@mail.gmail.com>
Message-ID: <CAGb2v654SNZcGVx9SXVvLfpz2kHchftyeL2sGOgnvj2T9G7KBA@mail.gmail.com>
Subject: Re: [PATCH v11 07/12] sun4i-codec: Add extra controls to
 sun4i_codec_quirks, sun7i_codec_quirks.
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Chen-Yu Tsai <wens@csie.org>, Linux-ALSA <alsa-devel@alsa-project.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 9, 2017 at 2:22 PM, Danny Milosavljevic
<dannym@scratchpost.org> wrote:
> Signed-off-by: Danny Milosavljevic <dannym@scratchpost.org>
> ---
>  sound/soc/sunxi/sun4i-codec.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c
> index b1da14d1..d453af65 100644
> --- a/sound/soc/sunxi/sun4i-codec.c
> +++ b/sound/soc/sunxi/sun4i-codec.c
> @@ -1576,6 +1576,8 @@ static const struct sun4i_codec_quirks sun4i_codec_quirks = {
>         .reg_adc_fifoc  = REG_FIELD(SUN4I_CODEC_ADC_FIFOC, 0, 31),
>         .reg_dac_txdata = SUN4I_CODEC_DAC_TXDATA,
>         .reg_adc_rxdata = SUN4I_CODEC_ADC_RXDATA,
> +       .controls = sun4i_codec_extra_controls,
> +       .num_controls = ARRAY_SIZE(sun4i_codec_extra_controls),

Where did these come from?

>  };
>
>  static const struct sun4i_codec_quirks sun6i_a31_codec_quirks = {
> @@ -1595,6 +1597,8 @@ static const struct sun4i_codec_quirks sun7i_codec_quirks = {
>         .reg_adc_fifoc  = REG_FIELD(SUN4I_CODEC_ADC_FIFOC, 0, 31),
>         .reg_dac_txdata = SUN4I_CODEC_DAC_TXDATA,
>         .reg_adc_rxdata = SUN4I_CODEC_ADC_RXDATA,
> +       .controls = sun7i_codec_extra_controls,
> +       .num_controls = ARRAY_SIZE(sun7i_codec_extra_controls),
>  };
>
>  static const struct sun4i_codec_quirks sun8i_a23_codec_quirks = {