From: Chen-Yu Tsai <wens@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: "Chen-Yu Tsai" <wens@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
dmurphy@ti.com, "Heiko Stübner" <heiko@sntech.de>,
jacek.anaszewski@gmail.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"Pavel Machek" <pavel@ucw.cz>, "Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH v2 2/3] arm64: dts: rockchip: rk3399-roc-pc: Fix MMC numbering for LED triggers
Date: Mon, 27 Apr 2020 22:45:34 +0800 [thread overview]
Message-ID: <CAGb2v65Gtm88MJTTw_MxB0sc8m5=EVzom7zw2Ro_UJgqjOQKkA@mail.gmail.com> (raw)
In-Reply-To: <a81840d3-813b-51b5-767c-e0d9d270200e@gmail.com>
On Mon, Apr 27, 2020 at 10:12 PM Johan Jonker <jbx6244@gmail.com> wrote:
>
> Hi,
>
> >> So for fixing up the LED node names, we'd probably want the following:
> >>
> >> diy_led: led-0
> >> yellow_led: led-1
> >> work_led: led-2
>
> Change proposal for led nodes to comply with preexisting dts.
> Does this work?
>
> diy_led: led_0: led-0
> yellow_led: led_1: led-1
> work_led: led_2: led-2
>
>
> blue: led_0: led-0
>
> A check does not give any warnings.
>
> make -k ARCH=arm dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/leds/leds-gpio.yaml
IMO the led_N labels are kind of useless... they don't convey the
information needed to identify the device.
A reader seeing
&led_0 {
linux,default_triggger = "activity";
};
in some device tree (overlay) has no idea what this snippet is supposed
to do. The person has to go back to the base dts / dtsi file to figure
that out.
But seriously, you should start a separate thread to discuss this issue.
ChenYu
> >
> > That doesn't look pretty either.
> > Would like to hear the maintainers view on how to handle other cases
> > without 'led' like for example 'blue' for mk808.
> >
next prev parent reply other threads:[~2020-04-27 14:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 7:31 [PATCH v2 0/3] arm64: dts: rockchip: misc. cleanups and improvements Chen-Yu Tsai
2020-04-27 7:31 ` [PATCH v2 1/3] dt-bindings: leds: common: Drop enumeration for linux,default-triggers Chen-Yu Tsai
2020-04-27 8:33 ` Johan Jonker
2020-04-27 9:21 ` Chen-Yu Tsai
2020-05-11 23:12 ` Rob Herring
2020-04-27 7:31 ` [PATCH v2 2/3] arm64: dts: rockchip: rk3399-roc-pc: Fix MMC numbering for LED triggers Chen-Yu Tsai
2020-04-27 8:57 ` Johan Jonker
2020-04-27 9:17 ` Chen-Yu Tsai
2020-04-27 10:08 ` Johan Jonker
2020-04-27 10:33 ` Chen-Yu Tsai
2020-04-27 10:55 ` Johan Jonker
2020-04-27 14:12 ` Johan Jonker
2020-04-27 14:45 ` Chen-Yu Tsai [this message]
2020-04-27 15:13 ` Robin Murphy
2020-04-27 7:31 ` [PATCH v2 3/3] arm64: dts: rockchip: rk3328-roc-cc: Set dr_mode to "host" for OTG Chen-Yu Tsai
2020-05-05 6:24 ` [PATCH v2 0/3] arm64: dts: rockchip: misc. cleanups and improvements Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v65Gtm88MJTTw_MxB0sc8m5=EVzom7zw2Ro_UJgqjOQKkA@mail.gmail.com' \
--to=wens@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=heiko@sntech.de \
--cc=jacek.anaszewski@gmail.com \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).