From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3735EC169C4 for ; Wed, 6 Feb 2019 13:10:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7DFA2175B for ; Wed, 6 Feb 2019 13:10:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728924AbfBFNKw (ORCPT ); Wed, 6 Feb 2019 08:10:52 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:36869 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727080AbfBFNKv (ORCPT ); Wed, 6 Feb 2019 08:10:51 -0500 Received: by mail-ed1-f68.google.com with SMTP id h15so5817141edb.4; Wed, 06 Feb 2019 05:10:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gTDf5mIG+VD+hRK89e1XhDrRXUiAwQjeJThZUW23oyE=; b=HSgBjXB9jjq7T9Xxdmq1gTkIIwvj01SyPxOM0YyUWb/8B03W7dGbyE9v+FdJwVOz5j CDczp3VNfZVlDbOpVf0o/mnZJEn+V8BdUef5BeklzqoFcYyvCGmKbADt0gd/4KiU1xlf 88h2ZD4zHFv3YjxeJxqPg0D/uuGd/pCLBaOcBnUdLfEwM723y6LuzCqPbx3WTgLUDbn9 9HDh1HCFwWknwxzk4NGLRXS4MRSeopxV1E4rtcDgFhpGxXOZVH7hhqFEEN6LIYoP95XF fL7711u7K2TsQwm6MB8bvxgvQ+oXaCVj0L/XBqngrazjH5vrUpMyG54SYfsOPcGfsK7P /Ghw== X-Gm-Message-State: AHQUAublxa8+i54o/u/mF3J1SZPDk5xk25ZDxUoWU6zjJ8aSPJaMXcOZ UOWTLTbJzuLEBLZGbbhIdetjdwZkqMg= X-Google-Smtp-Source: AHgI3IZMLyX0bkJLSQ/rxUPmQ+FCOMGuLj1BwZhbRWVX0tHLtEuJYVxyJahvj4FMfaJuteH77XdyCA== X-Received: by 2002:a17:906:5982:: with SMTP id j2mr7540557ejq.15.1549458649145; Wed, 06 Feb 2019 05:10:49 -0800 (PST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com. [209.85.128.46]) by smtp.gmail.com with ESMTPSA id p9sm296907eds.46.2019.02.06.05.10.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 05:10:48 -0800 (PST) Received: by mail-wm1-f46.google.com with SMTP id m1so2419738wml.2; Wed, 06 Feb 2019 05:10:48 -0800 (PST) X-Received: by 2002:a1c:494:: with SMTP id 142mr3143079wme.111.1549458648082; Wed, 06 Feb 2019 05:10:48 -0800 (PST) MIME-Version: 1.0 References: <20190131082308.22522-1-stefan@olimex.com> <20190131082308.22522-5-stefan@olimex.com> <4493d1cb-d1bb-bcc9-c37d-68c79f33e762@olimex.com> In-Reply-To: <4493d1cb-d1bb-bcc9-c37d-68c79f33e762@olimex.com> From: Chen-Yu Tsai Date: Wed, 6 Feb 2019 21:10:33 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 5/5] arm: dts: axpxx: add charge led node To: Stefan Mavrodiev Cc: Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:X-POWERS MULTIFUNCTION PMIC DEVICE DRIVERS" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 6, 2019 at 2:06 PM Stefan Mavrodiev wrote: > > > On 2/5/19 6:16 PM, Chen-Yu Tsai wrote: > > On Thu, Jan 31, 2019 at 4:25 PM Stefan Mavrodiev wrote: > >> Add dt node for axp20x-led driver controlling CHGLED. > >> Default status is disabled, since it may be not used. > >> > >> Signed-off-by: Stefan Mavrodiev > > Please include a cover letter for such a patch series. > Sorry, I will. > > > > Also, do any boards actually use this? I know the Pine64 does, but the > > LED is left to the user to populate. I would really like to have an in > > kernel user of this function, so that we can verify it. > > All boards made by Olimex has this led populated. The development and the > testing of the driver was done on A64-OLinuXino board. > > Should I make another patch, enabling the LED for the mention board? Yes please. I'll dig out my A33-OLinuXino next week to try it out. ChenYu > > > > ChenYu > > > >> --- > >> arch/arm/boot/dts/axp209.dtsi | 5 +++++ > >> arch/arm/boot/dts/axp22x.dtsi | 5 +++++ > >> arch/arm/boot/dts/axp81x.dtsi | 5 +++++ > >> 3 files changed, 15 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi > >> index 0d9ff12bdf28..f972b6f3ecd0 100644 > >> --- a/arch/arm/boot/dts/axp209.dtsi > >> +++ b/arch/arm/boot/dts/axp209.dtsi > >> @@ -69,6 +69,11 @@ > >> #gpio-cells = <2>; > >> }; > >> > >> + axp_led: led { > >> + compatible = "x-powers,axp20x-led"; > >> + status = "disabled"; > >> + }; > >> + > >> battery_power_supply: battery-power-supply { > >> compatible = "x-powers,axp209-battery-power-supply"; > >> status = "disabled"; > >> diff --git a/arch/arm/boot/dts/axp22x.dtsi b/arch/arm/boot/dts/axp22x.dtsi > >> index 65a07a67aca9..92a0b64252b1 100644 > >> --- a/arch/arm/boot/dts/axp22x.dtsi > >> +++ b/arch/arm/boot/dts/axp22x.dtsi > >> @@ -62,6 +62,11 @@ > >> #io-channel-cells = <1>; > >> }; > >> > >> + axp_led: led { > >> + compatible = "x-powers,axp20x-led"; > >> + status = "disabled"; > >> + }; > >> + > >> battery_power_supply: battery-power-supply { > >> compatible = "x-powers,axp221-battery-power-supply"; > >> status = "disabled"; > >> diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi > >> index bd83962d3627..22e243cc40d5 100644 > >> --- a/arch/arm/boot/dts/axp81x.dtsi > >> +++ b/arch/arm/boot/dts/axp81x.dtsi > >> @@ -74,6 +74,11 @@ > >> }; > >> }; > >> > >> + axp_led: led { > >> + compatible = "x-powers,axp20x-led"; > >> + status = "disabled"; > >> + }; > >> + > >> battery_power_supply: battery-power-supply { > >> compatible = "x-powers,axp813-battery-power-supply"; > >> status = "disabled"; > >> -- > >> 2.17.1 > >>