From: Chen-Yu Tsai <wens@csie.org>
To: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: Maxime Ripard <mripard@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-pwm@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] Re: [PATCH 5/6] pwm: sun4i: Add support to output source clock directly
Date: Sat, 27 Jul 2019 22:54:32 +0800 [thread overview]
Message-ID: <CAGb2v65a9jF3QsEQgTim_XxXjhd9K0KwDRxtqYMqsiy2yWLeBg@mail.gmail.com> (raw)
In-Reply-To: <4063694.66Ui2fGJfo@jernej-laptop>
On Sat, Jul 27, 2019 at 10:28 PM Jernej Škrabec <jernej.skrabec@siol.net> wrote:
>
> Dne sobota, 27. julij 2019 ob 12:50:08 CEST je Maxime Ripard napisal(a):
> > On Fri, Jul 26, 2019 at 08:40:44PM +0200, Jernej Skrabec wrote:
> > > PWM core has an option to bypass whole logic and output unchanged source
> > > clock as PWM output. This is achieved by enabling bypass bit.
> > >
> > > Note that when bypass is enabled, no other setting has any meaning, not
> > > even enable bit.
> > >
> > > This mode of operation is needed to achieve high enough frequency to
> > > serve as clock source for AC200 chip, which is integrated into same
> > > package as H6 SoC.
> > >
> > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> >
> > It doesn't seem to be available on the A10 (at least) though. The A13
> > seem to have it, so you should probably check that, and make that
> > conditional to the compatible if not available on all of them.
>
> Ok, can you suggest the name for the quirk? "has_bypass" is suspiciously
> similar to "has_prescaler_bypass".
has_direct_mod_clk_output?
> Also, how to name these sun4i_pwm_data structures? Now that there are (will
> be) three new quirks, name of the structure would be just too long, like
> "sun50i_pwm_dual_prescaler_bypass_clk_rst_bypass".
Just use the SoC model. Any later ones that have the same quirks will likely
use the same compatible string anyway.
ChenYu
next prev parent reply other threads:[~2019-07-27 14:55 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 18:40 [PATCH 0/6] pwm: sun4i: Add support for Allwinner H6 Jernej Skrabec
2019-07-26 18:40 ` [PATCH 1/6] dt-bindings: pwm: allwinner: Add H6 PWM description Jernej Skrabec
2019-07-27 10:42 ` Maxime Ripard
2019-07-26 18:40 ` [PATCH 2/6] pwm: sun4i: Add a quirk for reset line Jernej Skrabec
2019-07-27 10:42 ` Maxime Ripard
2019-07-29 6:36 ` Uwe Kleine-König
2019-07-29 6:43 ` Chen-Yu Tsai
2019-07-29 7:12 ` Uwe Kleine-König
2019-07-29 10:18 ` Philipp Zabel
2019-07-29 16:37 ` Maxime Ripard
2019-07-29 18:20 ` Uwe Kleine-König
2019-07-26 18:40 ` [PATCH 3/6] pwm: sun4i: Add a quirk for bus clock Jernej Skrabec
2019-07-27 10:46 ` Maxime Ripard
2019-07-27 14:15 ` Jernej Škrabec
2019-07-27 14:27 ` Chen-Yu Tsai
2019-07-29 6:38 ` Uwe Kleine-König
2019-07-29 15:48 ` Jernej Škrabec
2019-07-29 16:14 ` Uwe Kleine-König
2019-07-29 16:45 ` Maxime Ripard
2019-07-29 19:04 ` Uwe Kleine-König
2019-07-26 18:40 ` [PATCH 4/6] pwm: sun4i: Add support for H6 PWM Jernej Skrabec
2019-07-29 6:40 ` Uwe Kleine-König
2019-07-29 15:55 ` Jernej Škrabec
2019-07-29 16:07 ` Uwe Kleine-König
2019-07-29 16:09 ` [linux-sunxi] " Chen-Yu Tsai
2019-07-29 16:24 ` Uwe Kleine-König
2019-07-29 16:40 ` Jernej Škrabec
2019-07-29 18:40 ` Uwe Kleine-König
2019-07-29 18:46 ` Jernej Škrabec
2019-07-29 18:51 ` Uwe Kleine-König
2019-07-29 22:04 ` Jernej Škrabec
2019-07-30 8:09 ` Uwe Kleine-König
2019-07-30 8:32 ` Chen-Yu Tsai
2019-07-30 17:06 ` Maxime Ripard
2019-07-31 6:52 ` Uwe Kleine-König
2019-08-12 9:56 ` Maxime Ripard
2019-08-12 10:47 ` Uwe Kleine-König
2019-08-12 10:51 ` Jernej Škrabec
2019-07-26 18:40 ` [PATCH 5/6] pwm: sun4i: Add support to output source clock directly Jernej Skrabec
2019-07-27 10:50 ` Maxime Ripard
2019-07-27 14:28 ` Jernej Škrabec
2019-07-27 14:54 ` Chen-Yu Tsai [this message]
2019-07-29 7:06 ` Uwe Kleine-König
2019-07-29 16:16 ` Jernej Škrabec
2019-07-29 16:29 ` Uwe Kleine-König
2019-07-26 18:40 ` [PATCH 6/6] arm64: dts: allwinner: h6: Add PWM node Jernej Skrabec
2019-07-27 10:51 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v65a9jF3QsEQgTim_XxXjhd9K0KwDRxtqYMqsiy2yWLeBg@mail.gmail.com \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).