From: Chen-Yu Tsai <wens@csie.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
mo.ucina@gmail.com, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Chen-Yu Tsai <wens@csie.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: sun7i: lamobo-r1: Fix CPU port RGMII settings
Date: Mon, 20 Mar 2017 16:32:45 +0800 [thread overview]
Message-ID: <CAGb2v65m8JszJWjJs+ja66RVXeHpytSKNX61D2vf1Yp=kWCWFA@mail.gmail.com> (raw)
In-Reply-To: <20170320082956.sa2bwsoapp23srto@lukather>
Hi,
On Mon, Mar 20, 2017 at 4:29 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi Florian,
>
> On Sat, Mar 18, 2017 at 09:53:20PM -0700, Florian Fainelli wrote:
>> The CPU port of the BCM53125 is configured with RGMII (no delays) but
>> this should actually be RGMII with transmit delay (rgmii-txid) because
>> STMMAC takes care of inserting the transmitter delay. This fixes
>> occasional packet loss encountered.
>>
>> Fixes: d7b9eaff5f0c ("ARM: dts: sun7i: Add BCM53125 switch nodes to the lamobo-r1 board")
>> Reported-by: Hartmut Knaack <knaack.h@gmx.de>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Applied, thanks!
> Maxime
I'm not sure dwmac-sunxi supports "rgmii-txid" though.
At least I don't remember implementing it.
ChenYu
next prev parent reply other threads:[~2017-03-20 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-19 4:53 [PATCH] ARM: dts: sun7i: lamobo-r1: Fix CPU port RGMII settings Florian Fainelli
2017-03-20 8:29 ` Maxime Ripard
2017-03-20 8:32 ` Chen-Yu Tsai [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-19 4:50 Florian Fainelli
2017-03-22 4:06 ` Chen-Yu Tsai
2017-03-22 21:12 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v65m8JszJWjJs+ja66RVXeHpytSKNX61D2vf1Yp=kWCWFA@mail.gmail.com' \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mo.ucina@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).