From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752168AbbIQOVe (ORCPT ); Thu, 17 Sep 2015 10:21:34 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:39243 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751782AbbIQOVV (ORCPT ); Thu, 17 Sep 2015 10:21:21 -0400 MIME-Version: 1.0 In-Reply-To: <20150917112905.GC4684@lukather> References: <1442325957-10102-1-git-send-email-yassinjaffer@gmail.com> <1442325957-10102-3-git-send-email-yassinjaffer@gmail.com> <20150917112905.GC4684@lukather> From: Chen-Yu Tsai Date: Thu, 17 Sep 2015 22:20:56 +0800 Message-ID: Subject: Re: [linux-sunxi] Re: [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC To: yassinjaffer@gmail.com Cc: linux-sunxi , Dmitry Torokhov , "linux-input@vger.kernel.org" , linux-arm-kernel , linux-kernel , Maxime Ripard Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2015 at 7:29 PM, Maxime Ripard wrote: > Hi Yassin, > > On Wed, Sep 16, 2015 at 12:05:55AM +1000, yassinjaffer@gmail.com wrote: >> From: Yassin Jaffer >> >> Add Keypad controller node definition to the A20 SoC. >> >> Signed-off-by: Yassin Jaffer >> --- >> arch/arm/boot/dts/sun7i-a20.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi >> index 333604a..35cc8d0 100644 >> --- a/arch/arm/boot/dts/sun7i-a20.dtsi >> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi >> @@ -1198,6 +1198,15 @@ >> status = "disabled"; >> }; >> >> + kp: kp@01c23000 { > > The node name should reflect the class of the device. keypad@01c23000 > would be better for example. Expanding the label to "keypad" as well would be nice. "kp" could mean other things. Thanks. ChenYu > It looks good otherwise. > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.