From: Chen-Yu Tsai <wens@csie.org>
To: Stefan Mavrodiev <stefan@olimex.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:X-POWERS MULTIFUNCTION PMIC DEVICE DRIVERS"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] arm: dts: axpxx: add charge led node
Date: Wed, 6 Feb 2019 00:16:53 +0800 [thread overview]
Message-ID: <CAGb2v66B3X=hyCCanUv6yGziVcu3WrRcKODBp266ODL+yQ4m1w@mail.gmail.com> (raw)
In-Reply-To: <20190131082308.22522-5-stefan@olimex.com>
On Thu, Jan 31, 2019 at 4:25 PM Stefan Mavrodiev <stefan@olimex.com> wrote:
>
> Add dt node for axp20x-led driver controlling CHGLED.
> Default status is disabled, since it may be not used.
>
> Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
Please include a cover letter for such a patch series.
Also, do any boards actually use this? I know the Pine64 does, but the
LED is left to the user to populate. I would really like to have an in
kernel user of this function, so that we can verify it.
ChenYu
> ---
> arch/arm/boot/dts/axp209.dtsi | 5 +++++
> arch/arm/boot/dts/axp22x.dtsi | 5 +++++
> arch/arm/boot/dts/axp81x.dtsi | 5 +++++
> 3 files changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi
> index 0d9ff12bdf28..f972b6f3ecd0 100644
> --- a/arch/arm/boot/dts/axp209.dtsi
> +++ b/arch/arm/boot/dts/axp209.dtsi
> @@ -69,6 +69,11 @@
> #gpio-cells = <2>;
> };
>
> + axp_led: led {
> + compatible = "x-powers,axp20x-led";
> + status = "disabled";
> + };
> +
> battery_power_supply: battery-power-supply {
> compatible = "x-powers,axp209-battery-power-supply";
> status = "disabled";
> diff --git a/arch/arm/boot/dts/axp22x.dtsi b/arch/arm/boot/dts/axp22x.dtsi
> index 65a07a67aca9..92a0b64252b1 100644
> --- a/arch/arm/boot/dts/axp22x.dtsi
> +++ b/arch/arm/boot/dts/axp22x.dtsi
> @@ -62,6 +62,11 @@
> #io-channel-cells = <1>;
> };
>
> + axp_led: led {
> + compatible = "x-powers,axp20x-led";
> + status = "disabled";
> + };
> +
> battery_power_supply: battery-power-supply {
> compatible = "x-powers,axp221-battery-power-supply";
> status = "disabled";
> diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
> index bd83962d3627..22e243cc40d5 100644
> --- a/arch/arm/boot/dts/axp81x.dtsi
> +++ b/arch/arm/boot/dts/axp81x.dtsi
> @@ -74,6 +74,11 @@
> };
> };
>
> + axp_led: led {
> + compatible = "x-powers,axp20x-led";
> + status = "disabled";
> + };
> +
> battery_power_supply: battery-power-supply {
> compatible = "x-powers,axp813-battery-power-supply";
> status = "disabled";
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-02-05 16:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 8:23 [PATCH 1/5] leds: Add support for AXP20X CHGLED Stefan Mavrodiev
2019-01-31 8:23 ` [PATCH 2/5] mfd: axp20x: Add axp20x-led cell Stefan Mavrodiev
2019-01-31 8:23 ` [PATCH 3/5] dt-bindings: leds: Add binding for axp20x-led device driver Stefan Mavrodiev
2019-01-31 21:37 ` Jacek Anaszewski
2019-01-31 8:23 ` [PATCH 4/5] arm64: dts: allwinner: axp803: add charge led node Stefan Mavrodiev
2019-01-31 8:23 ` [PATCH 5/5] arm: dts: axpxx: " Stefan Mavrodiev
2019-02-05 16:16 ` Chen-Yu Tsai [this message]
2019-02-06 6:06 ` Stefan Mavrodiev
2019-02-06 13:10 ` Chen-Yu Tsai
2019-01-31 21:38 ` [PATCH 1/5] leds: Add support for AXP20X CHGLED Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v66B3X=hyCCanUv6yGziVcu3WrRcKODBp266ODL+yQ4m1w@mail.gmail.com' \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=stefan@olimex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).