From: Chen-Yu Tsai <wens@csie.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-sunxi@lists.linux.dev,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm64: dts: allwinner: h5: align operating-points table name with dtschema
Date: Fri, 20 Aug 2021 20:11:11 +0800 [thread overview]
Message-ID: <CAGb2v66EnW+iO2CPueauRob+b53pNFEuL6LUoSYb09_TN+=_cw@mail.gmail.com> (raw)
In-Reply-To: <20210820081645.83796-1-krzysztof.kozlowski@canonical.com>
On Fri, Aug 20, 2021 at 4:16 PM Krzysztof Kozlowski
<krzysztof.kozlowski@canonical.com> wrote:
>
> Align the name of operating-points node to dtschema to fix warnings like:
>
> arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dt.yaml:
> cpu-opp-table: $nodename:0: 'cpu-opp-table' does not match '^opp-table(-[a-z0-9]+)?$'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi
> index b2657201957e..0b6914a165b0 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-cpu-opp.dtsi
> @@ -2,7 +2,7 @@
> // Copyright (C) 2020 Chen-Yu Tsai <wens@csie.org>
>
> / {
> - cpu_opp_table: cpu-opp-table {
> + cpu_opp_table: opp-table-0 {
Maybe we should just reorder the name? Name it "opp-table-cpu" instead.
That way if and when we add one for the GPU, we don't accidentally
clash on the name.
ChenYu
next prev parent reply other threads:[~2021-08-20 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 8:16 [PATCH 1/2] arm64: dts: allwinner: h5: align operating-points table name with dtschema Krzysztof Kozlowski
2021-08-20 8:17 ` [PATCH 2/2] arm64: dts: allwinner: align thermal zone node names " Krzysztof Kozlowski
2021-08-20 12:06 ` Chen-Yu Tsai
2021-08-20 12:11 ` Chen-Yu Tsai [this message]
2021-08-20 12:48 ` [PATCH 1/2] arm64: dts: allwinner: h5: align operating-points table name " Krzysztof Kozlowski
2021-09-03 16:21 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v66EnW+iO2CPueauRob+b53pNFEuL6LUoSYb09_TN+=_cw@mail.gmail.com' \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).