From: Chen-Yu Tsai <wens@csie.org>
To: Samuel Holland <samuel@sholland.org>
Cc: Sebastian Reichel <sre@kernel.org>,
Oskari Lemmela <oskari@lemmela.net>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH v3 5/8] power: supply: axp20x_usb_power: Use a match structure
Date: Mon, 13 Jan 2020 12:08:55 +0800 [thread overview]
Message-ID: <CAGb2v66FsV9Gdm0Osgg5=Ebeh8-q4dVcWo1QoB8J9Ehag4XjkQ@mail.gmail.com> (raw)
In-Reply-To: <20200113035310.18950-6-samuel@sholland.org>
On Mon, Jan 13, 2020 at 11:53 AM Samuel Holland <samuel@sholland.org> wrote:
>
> Instead of ad-hoc variant ID checks throughout the code, let's start
> moving the variant-specific details to a match structure. This allows
> for future flexibility, and it better matches the other axp20x power
> supply drivers.
>
> This commit removes most variant checks from axp20x_usb_power_probe().
> Other parts of the driver still do ID matching; they are left unchanged
> for now.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
next prev parent reply other threads:[~2020-01-13 4:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 3:53 [PATCH v3 0/8] X-Powers Power Supply Improvements Samuel Holland
2020-01-13 3:53 ` [PATCH v3 1/8] power: supply: axp20x_ac_power: Fix reporting online status Samuel Holland
2020-01-13 4:04 ` Chen-Yu Tsai
2020-01-13 3:53 ` [PATCH v3 2/8] power: supply: axp20x_ac_power: Allow offlining Samuel Holland
2020-01-13 3:53 ` [PATCH v3 3/8] power: supply: axp20x_ac_power: Add wakeup control Samuel Holland
2020-01-13 3:53 ` [PATCH v3 4/8] power: supply: axp20x_usb_power: Remove unused device_node Samuel Holland
2020-01-13 3:53 ` [PATCH v3 5/8] power: supply: axp20x_usb_power: Use a match structure Samuel Holland
2020-01-13 4:08 ` Chen-Yu Tsai [this message]
2020-01-13 3:53 ` [PATCH v3 6/8] power: supply: axp20x_usb_power: Allow offlining Samuel Holland
2020-01-13 4:05 ` [linux-sunxi] " Chen-Yu Tsai
2020-01-13 3:53 ` [PATCH v3 7/8] power: supply: axp20x_usb_power: Add wakeup control Samuel Holland
2020-01-13 3:53 ` [PATCH v3 8/8] power: supply: axp20x_usb_power: Only poll while offline Samuel Holland
2020-01-14 0:17 ` [PATCH v3 0/8] X-Powers Power Supply Improvements Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v66FsV9Gdm0Osgg5=Ebeh8-q4dVcWo1QoB8J9Ehag4XjkQ@mail.gmail.com' \
--to=wens@csie.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=oskari@lemmela.net \
--cc=samuel@sholland.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).