From: Chen-Yu Tsai <wens@csie.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
linux-clk <linux-clk@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v3 07/11] ARM: sunxi: h3/h5: add simplefb nodes
Date: Fri, 29 Dec 2017 16:45:18 +0800 [thread overview]
Message-ID: <CAGb2v66LGkzscbpCAwhPvA2VPL-8Qpc+e5vNFPq6vS2Hvh9DbA@mail.gmail.com> (raw)
In-Reply-To: <20171222122243.25735-8-icenowy@aosc.io>
On Fri, Dec 22, 2017 at 8:22 PM, Icenowy Zheng <icenowy@aosc.io> wrote:
> The H3/H5 SoCs have a HDMI output and a TV Composite output.
>
> Add simplefb nodes for these outputs.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index fcb909658cf0..31478c03790d 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -53,6 +53,35 @@
> #address-cells = <1>;
> #size-cells = <1>;
>
> + chosen {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + framebuffer-hdmi {
> + compatible = "allwinner,simple-framebuffer",
> + "simple-framebuffer";
> + allwinner,pipeline = "mixer0-lcd0-hdmi";
> + clocks = <&display_clocks CLK_BUS_MIXER0>,
> + <&ccu CLK_BUS_TCON0>, <&ccu CLK_BUS_HDMI>,
Are the bus clocks necessary? It's not like simplefb is going to access
any of the control registers.
> + <&display_clocks CLK_MIXER0>,
> + <&ccu CLK_TCON0>, <&ccu CLK_HDMI>,
> + <&ccu CLK_HDMI_DDC>;
Is the DDC clock necessary? There's no usage of DDC with simplefb.
ChenYu
> + status = "disabled";
> + };
> +
> + framebuffer-tve {
> + compatible = "allwinner,simple-framebuffer",
> + "simple-framebuffer";
> + allwinner,pipeline = "mixer1-lcd1-tve";
> + clocks = <&display_clocks CLK_BUS_MIXER1>,
> + <&ccu CLK_BUS_TCON1>, <&ccu CLK_BUS_TVE>,
> + <&display_clocks CLK_MIXER1>,
> + <&ccu CLK_TVE>;
> + status = "disabled";
> + };
> + };
> +
> clocks {
> #address-cells = <1>;
> #size-cells = <1>;
> --
> 2.14.2
>
next prev parent reply other threads:[~2017-12-29 8:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-22 12:22 [PATCH v3 00/11] Allwinner H3/H5/A64(DE2) SimpleFB support Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 01/11] dt-bindings: fix the binding of Allwinner DE2 CCU of A83T and H3 Icenowy Zheng
2017-12-26 19:00 ` Rob Herring
2017-12-22 12:22 ` [PATCH v3 02/11] clk: sunxi-ng: add support for Allwinner H3 DE2 CCU Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 03/11] clk: sunxi-ng: fix the A64/H5 clock description of " Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 04/11] dt-bindings: simplefb-sunxi: add pipelines for DE2 Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 05/11] ARM: sun8i: h3/h5: add DE2 CCU device node for H3 Icenowy Zheng
2018-01-04 13:39 ` maxime.ripard
2017-12-22 12:22 ` [PATCH v3 06/11] arm64: allwinner: h5: add compatible string for DE2 CCU Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 07/11] ARM: sunxi: h3/h5: add simplefb nodes Icenowy Zheng
2017-12-29 8:45 ` Chen-Yu Tsai [this message]
2017-12-22 12:22 ` [PATCH v3 08/11] dt-bindings: add binding for A64 DE2 CCU SRAM Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 09/11] clk: sunxi-ng: add support for Allwinner A64 DE2 CCU Icenowy Zheng
2017-12-29 8:35 ` Chen-Yu Tsai
2018-01-04 13:41 ` Maxime Ripard
2017-12-22 12:22 ` [PATCH v3 10/11] arm64: allwinner: a64: add DE2 CCU for A64 SoC Icenowy Zheng
2017-12-22 12:22 ` [PATCH v3 11/11] arm64: allwinner: a64: add simplefb " Icenowy Zheng
2017-12-27 4:09 ` [PATCH v3 00/11] Allwinner H3/H5/A64(DE2) SimpleFB support Chen-Yu Tsai
2017-12-27 4:10 ` Icenowy Zheng
2017-12-27 4:23 ` Chen-Yu Tsai
2017-12-29 8:52 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v66LGkzscbpCAwhPvA2VPL-8Qpc+e5vNFPq6vS2Hvh9DbA@mail.gmail.com \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).