From: Chen-Yu Tsai <wens@csie.org>
To: Maxime Ripard <mripard@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
Maxime Ripard <maxime.ripard@bootlin.com>
Subject: Re: [PATCH 4/5] ARM: dts: sun8i: a83t: Remove the watchdog clock
Date: Wed, 14 Aug 2019 12:38:51 +0800 [thread overview]
Message-ID: <CAGb2v66mp-=T=-zDYMf6Qw-vaiR3OB5Xhxie39jeKWS+Kvmecw@mail.gmail.com> (raw)
In-Reply-To: <20190813124744.32614-4-mripard@kernel.org>
On Tue, Aug 13, 2019 at 8:47 PM Maxime Ripard <mripard@kernel.org> wrote:
>
> From: Maxime Ripard <maxime.ripard@bootlin.com>
>
> The watchdog binding doesn't define a clock, and it indeed looks like
> there's no explicit clock feeding it.
The diagram on page 133 of the manual shows OSC24M / 750 feeding the watchdog.
Other manuals, such as the A10 one, mention:
Watchdog clock source is OSC24M. if the OSC24M is turned off, the watchdog
will not work.
So in fact it does use a clock signal. It's just that we've been lazy, since
the clock rate is fixed and is always on.
ChenYu
> Let's remove it from our DT.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
> arch/arm/boot/dts/sun8i-a83t.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> index 523be6611c50..15f8c80f69a5 100644
> --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> @@ -817,7 +817,6 @@
> compatible = "allwinner,sun6i-a31-wdt";
> reg = <0x01c20ca0 0x20>;
> interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&osc24M>;
> };
>
> spdif: spdif@1c21000 {
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-08-14 4:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 12:47 [PATCH 1/5] dt-bindings: mfd: Convert Allwinner GPADC bindings to a schema Maxime Ripard
2019-08-13 12:47 ` [PATCH 2/5] dt-bindings: watchdog: Convert Allwinner watchdog " Maxime Ripard
2019-08-13 21:30 ` Rob Herring
2019-08-13 12:47 ` [PATCH 3/5] dt-bindings: watchdog: sun4i: Add the watchdog interrupts Maxime Ripard
2019-08-13 21:32 ` Rob Herring
2019-08-13 12:47 ` [PATCH 4/5] ARM: dts: sun8i: a83t: Remove the watchdog clock Maxime Ripard
2019-08-14 4:38 ` Chen-Yu Tsai [this message]
2019-08-13 12:47 ` [PATCH 5/5] ARM: dts: sunxi: Add missing watchdog interrupts Maxime Ripard
2019-08-14 4:44 ` Chen-Yu Tsai
2019-08-19 17:51 ` Maxime Ripard
2019-08-13 21:28 ` [PATCH 1/5] dt-bindings: mfd: Convert Allwinner GPADC bindings to a schema Rob Herring
2019-08-19 18:27 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v66mp-=T=-zDYMf6Qw-vaiR3OB5Xhxie39jeKWS+Kvmecw@mail.gmail.com' \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).