From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030709AbdAEGEF convert rfc822-to-8bit (ORCPT ); Thu, 5 Jan 2017 01:04:05 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:35476 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030666AbdAEGDG (ORCPT ); Thu, 5 Jan 2017 01:03:06 -0500 MIME-Version: 1.0 In-Reply-To: <20170104115731.GF24058@dell> References: <20170102163723.7939-1-quentin.schulz@free-electrons.com> <20170102163723.7939-17-quentin.schulz@free-electrons.com> <20170104115731.GF24058@dell> From: Chen-Yu Tsai Date: Thu, 5 Jan 2017 14:02:40 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 16/22] mfd: axp20x: add V_OFF to writeable regs for AXP20X and AXP22X To: Lee Jones Cc: Quentin Schulz , Jonathan Cameron , knaack.h@gmx.de, Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , Chen-Yu Tsai , Sebastian Reichel , Russell King , Maxime Ripard , linux-iio@vger.kernel.org, devicetree , linux-kernel , "open list:THERMAL" , linux-arm-kernel , Thomas Petazzoni , Icenowy Zheng , =?UTF-8?Q?Bruno_Pr=C3=A9mont?= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 4, 2017 at 7:57 PM, Lee Jones wrote: > On Mon, 02 Jan 2017, Quentin Schulz wrote: > >> The V_OFF register has its first 3 read-write bits for the minimal >> voltage (Voff) of the battery before the system is automatically shut >> down due to the power being too low. >> >> This adds V_OFF register to the writeable registers of AXP20X and AXP22X >> PMICs. >> >> Signed-off-by: Quentin Schulz >> --- >> drivers/mfd/axp20x.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > For my own reference: > Acked-for-MFD-by: Lee Jones Acked-by: Chen-Yu Tsai > >> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c >> index 19bdba3..7f0f05f 100644 >> --- a/drivers/mfd/axp20x.c >> +++ b/drivers/mfd/axp20x.c >> @@ -65,7 +65,7 @@ static const struct regmap_access_table axp152_volatile_table = { >> >> static const struct regmap_range axp20x_writeable_ranges[] = { >> regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_IRQ5_STATE), >> - regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_VBUS_IPSOUT_MGMT), >> + regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_V_OFF), >> regmap_reg_range(AXP20X_CHRG_CTRL1, AXP20X_CHRG_CTRL1), >> regmap_reg_range(AXP20X_DCDC_MODE, AXP20X_FG_RES), >> regmap_reg_range(AXP20X_RDC_H, AXP20X_OCV(AXP20X_OCV_MAX)), >> @@ -94,7 +94,7 @@ static const struct regmap_access_table axp20x_volatile_table = { >> /* AXP22x ranges are shared with the AXP809, as they cover the same range */ >> static const struct regmap_range axp22x_writeable_ranges[] = { >> regmap_reg_range(AXP20X_DATACACHE(0), AXP20X_IRQ5_STATE), >> - regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_VBUS_IPSOUT_MGMT), >> + regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_V_OFF), >> regmap_reg_range(AXP20X_CHRG_CTRL1, AXP20X_CHRG_CTRL1), >> regmap_reg_range(AXP20X_DCDC_MODE, AXP22X_BATLOW_THRES1), >> }; > > -- > Lee Jones > Linaro STMicroelectronics Landing Team Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog