From: Chen-Yu Tsai <wens@csie.org>
To: Alexander Syring <alex@asyring.de>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-clk <linux-clk@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: sunxi-ng: Fix missing CLK_SET_RATE_PARENT in ccu-sun4i-a10.c
Date: Thu, 14 Sep 2017 20:14:10 +0800 [thread overview]
Message-ID: <CAGb2v677Ed4-iX6fkYEYZ1N9ZLKXfQQF2hhdbcbBCaB0-g174A@mail.gmail.com> (raw)
In-Reply-To: <20170914120519.2006-1-alex@asyring.de>
On Thu, Sep 14, 2017 at 8:05 PM, Alexander Syring <alex@asyring.de> wrote:
> When using cpufreq-dt with default govenor other than "performance"
> system freezes while booting.
> Adding CLK_SET_RATE_PARENT | CLK_IS_CRITICAL to clk_cpu fixes the
> problem.
>
> Tested on Cubietruck (A20).
>
> Fixes: c84f5683f6E ("clk: sunxi-ng: Add sun4i/sun7i CCU driver")
>
> Reported-by: Alexander Syring <alex@asyring.de>
You typically don't need this if you yourself are the reporter.
> Signed-off-by: Alexander Syring <alex@asyring.de>
Acked-by: Chen-Yu Tsai <wens@csie.org>
> ---
> drivers/clk/sunxi-ng/ccu-sun4i-a10.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun4i-a10.c b/drivers/clk/sunxi-ng/ccu-sun4i-a10.c
> index 286b0049b7b6..a48fde191c0a 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun4i-a10.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun4i-a10.c
> @@ -223,7 +223,7 @@ static struct ccu_mux cpu_clk = {
> .hw.init = CLK_HW_INIT_PARENTS("cpu",
> cpu_parents,
> &ccu_mux_ops,
> - CLK_IS_CRITICAL),
> + CLK_SET_RATE_PARENT | CLK_IS_CRITICAL),
> }
> };
>
> --
> 2.11.0
>
next prev parent reply other threads:[~2017-09-14 12:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 12:05 [PATCH] clk: sunxi-ng: Fix missing CLK_SET_RATE_PARENT in ccu-sun4i-a10.c Alexander Syring
2017-09-14 12:14 ` Chen-Yu Tsai [this message]
2017-09-15 9:47 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v677Ed4-iX6fkYEYZ1N9ZLKXfQQF2hhdbcbBCaB0-g174A@mail.gmail.com \
--to=wens@csie.org \
--cc=alex@asyring.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).