From: Chen-Yu Tsai <wens@kernel.org>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: axp20x-pek - make device attributes static
Date: Wed, 18 Dec 2019 11:00:00 +0800 [thread overview]
Message-ID: <CAGb2v67ADBH+JtsA9d4Rc84uMjvPXPB4JG2DdVaU+m3C4CGu7g@mail.gmail.com> (raw)
In-Reply-To: <20191217152541.2167080-1-ben.dooks@codethink.co.uk>
On Tue, Dec 17, 2019 at 11:25 PM Ben Dooks (Codethink)
<ben.dooks@codethink.co.uk> wrote:
>
> The two device attrbitues are not declared outside this file
> so make them static to avoid the following warnings:
>
> drivers/input/misc/axp20x-pek.c:194:1: warning: symbol 'dev_attr_startup' was not declared. Should it be static?
> drivers/input/misc/axp20x-pek.c:195:1: warning: symbol 'dev_attr_shutdown' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: linux-input@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
Acked-by: Chen-Yu Tsai <wens@csie.org>
prev parent reply other threads:[~2019-12-18 3:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 15:25 [PATCH] Input: axp20x-pek - make device attributes static Ben Dooks (Codethink)
2019-12-18 3:00 ` Chen-Yu Tsai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v67ADBH+JtsA9d4Rc84uMjvPXPB4JG2DdVaU+m3C4CGu7g@mail.gmail.com \
--to=wens@kernel.org \
--cc=ben.dooks@codethink.co.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).