From: Chen-Yu Tsai <wens@csie.org>
To: jorik@kippendief.biz
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/7] dts: sun8i-h3: add pinmux definitions for i2c0/i2c1
Date: Thu, 1 Sep 2016 10:45:42 +0800 [thread overview]
Message-ID: <CAGb2v67JW0M7jELmQ5mwCQT5ZCMQc+J+sPNVe5HbJO64UOVrBg@mail.gmail.com> (raw)
In-Reply-To: <1472671858-29220-3-git-send-email-jorik@kippendief.biz>
On Thu, Sep 1, 2016 at 3:30 AM, <jorik@kippendief.biz> wrote:
> From: Jorik Jonker <jorik@kippendief.biz>
>
> This adds proper pinmux definitions for i2c0 and i2c1. Although H3 has a third
> i2c controller, these are not exposed on my boards. If someone actually has a
> H3 board with an exposed i2c2, they could add the third.
>
> Signed-off-by: Jorik Jonker <jorik@kippendief.biz>
> ---
> arch/arm/boot/dts/sun8i-h3.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index 7740748..0637b95 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -327,6 +327,20 @@
> interrupt-controller;
> #interrupt-cells = <3>;
>
> + i2c0_pins_a: i2c0@0 {
> + allwinner,pins = "PA11", "PA12";
> + allwinner,function = "i2c0";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> +
> + i2c1_pins_a: i2c1@0 {
These pinmuxes are the only ones possible for each peripheral.
Please drop the _a suffix and the @0 address for both of them.
ChenYu
> + allwinner,pins = "PA18", "PA19";
> + allwinner,function = "i2c1";
> + allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
> + };
> +
> mmc0_pins_a: mmc0@0 {
> allwinner,pins = "PF0", "PF1", "PF2", "PF3",
> "PF4", "PF5";
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-09-01 2:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 19:30 [PATCH v2 0/7] dts: sun8i: add extra uart/i2c to H3 jorik
2016-08-31 19:30 ` [PATCH v2 1/7] dts: sun8i-h3: add pinmux definitions for uart2/uart3 jorik
2016-08-31 19:30 ` [PATCH v2 2/7] dts: sun8i-h3: add pinmux definitions for i2c0/i2c1 jorik
2016-09-01 2:45 ` Chen-Yu Tsai [this message]
2016-08-31 19:30 ` [PATCH v2 3/7] dts: sun8i-h3: add i2c0/i2c1 SoC peripherals jorik
2016-09-01 2:42 ` Chen-Yu Tsai
2016-09-01 6:34 ` Jorik Jonker
[not found] ` <CAKqGPHwBqWn05SQqEPUQiwxi=WyBJ2LFto2Ucbh8w=Eqe49eTA@mail.gmail.com>
2016-09-01 6:42 ` Chen-Yu Tsai
2016-08-31 19:30 ` [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus jorik
2016-09-02 7:04 ` Maxime Ripard
2016-09-03 12:09 ` Jorik Jonker
2016-09-05 19:31 ` Maxime Ripard
2016-09-06 3:04 ` Chen-Yu Tsai
2016-09-06 8:52 ` Jorik Jonker
2016-09-06 20:01 ` Maxime Ripard
2016-09-06 20:02 ` Maxime Ripard
2016-08-31 19:30 ` [PATCH v2 5/7] dts: sun8i-h3: add UART1-3 to Orange Pi PC jorik
2016-08-31 19:30 ` [PATCH v2 6/7] dts: sun8i-h3: add I2C0-1 to Orange Pi Plus jorik
2016-08-31 19:30 ` [PATCH v2 7/7] dts: sun8i-h3: add I2C0-1 to Orange Pi PC jorik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v67JW0M7jELmQ5mwCQT5ZCMQc+J+sPNVe5HbJO64UOVrBg@mail.gmail.com \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=jorik@kippendief.biz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).