From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65BBFC2BA2B for ; Thu, 9 Apr 2020 15:20:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 140F62082D for ; Thu, 9 Apr 2020 15:20:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728081AbgDIPUO (ORCPT ); Thu, 9 Apr 2020 11:20:14 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:46297 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727736AbgDIPUO (ORCPT ); Thu, 9 Apr 2020 11:20:14 -0400 Received: by mail-ed1-f67.google.com with SMTP id dk4so87090edb.13; Thu, 09 Apr 2020 08:20:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4T/yNw7Oi6CyzIIjkIvIk0WZLkoS1PM8XtkC6qecQpw=; b=Rd4Hq+2tWp1D5xZlbEF7k3mWfg93I28KWIiMG+/MUKvJmmk/NfAGJWWn3ZWb88g44i bGFkQm2qHfI/JXf9YCc6/YvGav8daVwEX7Cy9YzjIYhBmlYAS601AAxqIxQpOQEo0FXl qyiP3oYGdcDKCpFCySfAV5G1TDIrXUfFr40T7QpzVe7wr9fRIju5b4hwOhUjtTE7sMK2 4Y8niK/VW4cKFmYhxIgyshYeip8UUA96BKFZ6Fw/F+aQx+V2nw2TGTkkzwcBMENVTz3Q ZOIu54YI7HzwqiD0/DNasFo5ThK2AcnGKS72f2MXFc7oezs1aIBx4ku9X9m0PxhCVfLi 79ew== X-Gm-Message-State: AGi0PuZnVAXHS5KcBywAUYAwetUIqDX5oHNXnfAoVZPtX1pnh/yH9jJp ZN4BhGgppaNJz3ZH4Z6pwo5zsY5+jfs= X-Google-Smtp-Source: APiQypLzhOk9igLGVjMXkxH/DSVCCMzI03tU371UYoJDa/NnEpxvHALpHL3oty0t0v+vVGWWjK8C0w== X-Received: by 2002:aa7:c0d4:: with SMTP id j20mr516713edp.288.1586445611793; Thu, 09 Apr 2020 08:20:11 -0700 (PDT) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com. [209.85.221.47]) by smtp.gmail.com with ESMTPSA id y23sm328621eju.85.2020.04.09.08.20.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2020 08:20:11 -0700 (PDT) Received: by mail-wr1-f47.google.com with SMTP id g3so12405660wrx.2; Thu, 09 Apr 2020 08:20:10 -0700 (PDT) X-Received: by 2002:a5d:4011:: with SMTP id n17mr12170370wrp.104.1586445610677; Thu, 09 Apr 2020 08:20:10 -0700 (PDT) MIME-Version: 1.0 References: <20200317155906.31288-1-dev@pascalroeleven.nl> <20200317155906.31288-3-dev@pascalroeleven.nl> In-Reply-To: <20200317155906.31288-3-dev@pascalroeleven.nl> From: Chen-Yu Tsai Date: Thu, 9 Apr 2020 23:19:59 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 2/4] pwm: sun4i: Disable pwm before turning off clock gate To: Pascal Roeleven Cc: Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Maxime Ripard , Philipp Zabel , linux-pwm@vger.kernel.org, linux-arm-kernel , linux-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2020 at 12:00 AM Pascal Roeleven wrote: > > The clock gate must stay on when disabling to ensure proper turning off. > After one period it will still be disabled anyway. > > Signed-off-by: Pascal Roeleven Reviewed-by: Chen-Yu Tsai