From: Chen-Yu Tsai <wens@csie.org>
To: Mans Rullgard <mans@mansr.com>
Cc: Maxime Ripard <mripard@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: sunxi: h3/h5: add r_pwm node
Date: Thu, 27 Feb 2020 11:03:02 +0800 [thread overview]
Message-ID: <CAGb2v67ka=7n0BHw_UDY4AH+PmvEJDTrr8JZUB2e5jCXdgSq3Q@mail.gmail.com> (raw)
In-Reply-To: <20200226183316.26159-1-mans@mansr.com>
On Thu, Feb 27, 2020 at 2:33 AM Mans Rullgard <mans@mansr.com> wrote:
>
> There is a second PWM unit available in the PL I/O block.
> Add a node and pinmux definition for it.
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 107eeafad20a..1842c9f12c36 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -871,6 +871,19 @@
> pins = "PL0", "PL1";
> function = "s_i2c";
> };
> +
> + r_pwm_pins: r-pwm-pins {
Since it's just one pin, you could use the singular form instead.
And also set it as the default.
With that,
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> + pins = "PL10";
> + function = "s_pwm";
> + };
> + };
> +
> + r_pwm: pwm@1f03800 {
> + compatible = "allwinner,sun8i-h3-pwm";
> + reg = <0x01f03800 0x8>;
> + clocks = <&osc24M>;
> + #pwm-cells = <3>;
> + status = "disabled";
> };
> };
> };
> --
> 2.25.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-02-27 3:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 18:33 [PATCH] ARM: dts: sunxi: h3/h5: add r_pwm node Mans Rullgard
2020-02-27 3:03 ` Chen-Yu Tsai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v67ka=7n0BHw_UDY4AH+PmvEJDTrr8JZUB2e5jCXdgSq3Q@mail.gmail.com' \
--to=wens@csie.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).