From: 郭力豪 <lhjeff911@gmail.com>
To: "Lh Kuo 郭力豪" <lh.Kuo@sunplus.com>
Cc: Tom Rix <trix@redhat.com>,
"nathan@kernel.org" <nathan@kernel.org>,
"ndesaulniers@google.com" <ndesaulniers@google.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] spi: initialize ret variable
Date: Thu, 10 Feb 2022 10:45:46 +0800 [thread overview]
Message-ID: <CAGcXWkyF8FdRNP7=pcLQw339QpVX82op+zEMS7KrXXZJ8SLMQw@mail.gmail.com> (raw)
In-Reply-To: <27a1822d798641f5bba33d7529ec02c0@sphcmbx02.sunplus.com.tw>
>Yes, that's what I'm asking.
>The original setting was ret=0; I just wanted to remove it when defining
>the ret, but it looks like it's required.
>Yes, it should return error at default
>I will submit new patch for this.
> The old behavior returned 0 and I am treating this as a regression.
The goal here isn't just to shut up warnings, it's to fix any problems
that they identify. Unconditionally initialising return values is a
common way of fixing warnings while leaving real problems in place.
The original setting was ret=0; I just wanted to remove it when defining
the ret, but it looks like it's required.
Yes, it should return error at default
I will submit new patch for this.
prev parent reply other threads:[~2022-02-10 2:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 16:30 [PATCH] spi: initialize ret variable trix
2022-02-09 16:33 ` Mark Brown
2022-02-09 16:44 ` Tom Rix
2022-02-09 17:04 ` Mark Brown
[not found] ` <CAGcXWkyCQ4JExvHv3cEL7vLMOcq_iPu0vOyOmnfzbQmMxHEp=Q@mail.gmail.com>
[not found] ` <27a1822d798641f5bba33d7529ec02c0@sphcmbx02.sunplus.com.tw>
2022-02-10 2:45 ` 郭力豪 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGcXWkyF8FdRNP7=pcLQw339QpVX82op+zEMS7KrXXZJ8SLMQw@mail.gmail.com' \
--to=lhjeff911@gmail.com \
--cc=broonie@kernel.org \
--cc=lh.Kuo@sunplus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).