From: Xinliang Liu <xinliang.liu@linaro.org>
To: John Garry <john.garry@huawei.com>
Cc: "Liuxinliang (Matthew Liu)" <z.liuxinliang@hisilicon.com>,
XinWei Kong <kong.kongxinwei@hisilicon.com>,
Feng Chen <puck.chen@hisilicon.com>,
David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
baowenyi@huawei.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linuxarm <linuxarm@huawei.com>,
Rongrong Zou <zourongrong@gmail.com>
Subject: Re: [PATCH 0/3] HiBMC driver fixes
Date: Wed, 26 Sep 2018 11:00:12 +0800 [thread overview]
Message-ID: <CAGd==05wySTNy9rOrv7Hb3V1ihD9wQZjN+v5RrfmG=0DAwsUsA@mail.gmail.com> (raw)
In-Reply-To: <1537550727-21257-1-git-send-email-john.garry@huawei.com>
Thanks John, good addressing!
The root cause as you said, our hibmc previous frame buffer format
depth setting is wrong which does not pass the new format sanity
checking drm_mode_legacy_fb_format.
For this series, Reviewed-by: Xinliang Liu <z.liuxinliang@hisilicon.com>
Applied to hisilicon-drm-next.
Thanks,
Xinliang
On Sun, 23 Sep 2018 at 20:32, John Garry <john.garry@huawei.com> wrote:
>
> This patchset fixes a couple of issues in probing the HiBMC driver, as
> follows:
> - fix the probe error path to not carry an error code in the pointer
> - don't use invalid legacy fb bpp/depth combination
>
> Another more trivial patch is for using the standard Huawei PCI vendor ID
> instead of hard-coding it.
>
> Tested on Huawei D05 board. I can see tux on BMC VGA console.
>
> John Garry (3):
> drm/hisilicon: hibmc: Do not carry error code in HiBMC framebuffer
> pointer
> drm/hisilicon: hibmc: Don't overwrite fb helper surface depth
> drm/hisilicon: hibmc: Use HUAWEI PCI vendor ID macro
>
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 +-
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-09-26 3:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 17:25 [PATCH 0/3] HiBMC driver fixes John Garry
2018-09-21 17:25 ` [PATCH 1/3] drm/hisilicon: hibmc: Do not carry error code in HiBMC framebuffer pointer John Garry
2018-09-21 17:25 ` [PATCH 2/3] drm/hisilicon: hibmc: Don't overwrite fb helper surface depth John Garry
2018-09-21 17:25 ` [PATCH 3/3] drm/hisilicon: hibmc: Use HUAWEI PCI vendor ID macro John Garry
2018-09-26 3:00 ` Xinliang Liu [this message]
2018-09-26 8:46 ` [PATCH 0/3] HiBMC driver fixes John Garry
2018-09-26 9:41 ` Xinliang Liu
2018-09-26 9:53 ` John Garry
2018-09-27 8:42 ` Xinliang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGd==05wySTNy9rOrv7Hb3V1ihD9wQZjN+v5RrfmG=0DAwsUsA@mail.gmail.com' \
--to=xinliang.liu@linaro.org \
--cc=airlied@linux.ie \
--cc=baowenyi@huawei.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=john.garry@huawei.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=puck.chen@hisilicon.com \
--cc=z.liuxinliang@hisilicon.com \
--cc=zourongrong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).