From: Kevin Loughlin <kevinloughlin@google.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
Michael Kelley <mikelley@microsoft.com>,
Pankaj Gupta <pankaj.gupta@amd.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Arnd Bergmann <arnd@arndb.de>,
Steve Rutherford <srutherford@google.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Hou Wenlong <houwenlong.hwl@antgroup.com>,
Vegard Nossum <vegard.nossum@oracle.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Yuntao Wang <ytcoode@gmail.com>,
Wang Jinchao <wangjinchao@xfusion.com>,
David Woodhouse <dwmw@amazon.co.uk>,
Brian Gerst <brgerst@gmail.com>, Hugh Dickins <hughd@google.com>,
Ard Biesheuvel <ardb@kernel.org>, Joerg Roedel <jroedel@suse.de>,
Randy Dunlap <rdunlap@infradead.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Dionna Glaze <dionnaglaze@google.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Michael Roth <michael.roth@amd.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
linux-coco@lists.linux.dev, Ashish Kalra <ashish.kalra@amd.com>,
Andi Kleen <ak@linux.intel.com>,
Adam Dunlap <acdunlap@google.com>,
Peter Gonda <pgonda@google.com>, Jacob Xu <jacobhxu@google.com>,
Sidharth Telang <sidtelang@google.com>
Subject: Re: [RFC PATCH v2] x86/sev: enforce RIP-relative accesses in early SEV/SME code
Date: Tue, 16 Jan 2024 14:13:24 -0800 [thread overview]
Message-ID: <CAGdbjmLrH_fZMS6pCX5pNKCJ2jLm1xAcJkHv5R4Z7MycvhbR5A@mail.gmail.com> (raw)
In-Reply-To: <20240115101239.nab725vuazvutgw6@box.shutemov.name>
On Mon, Jan 15, 2024 at 2:12 AM Kirill A. Shutemov
<kirill.shutemov@linux.intel.com> wrote:
>
> On Fri, Jan 12, 2024 at 10:29:36AM -0800, Kevin Loughlin wrote:
> >
> > Per my tests, yes we can; I replaced the fixup_*() functions with
> > GET_RIP_RELATIVE_PTR()/PTR_TO_RIP_RELATIVE_PTR(), and guests with and
> > without SEV, SEV-ES, and SEV-SNP all successfully booted under both
> > clang and gcc builds.
>
> BTW, do we need both macros? Caller can do &var, right?
While I don't think the caller doing "&var" would work without passing
it as a separate argument like `GET_RIP_RELATIVE_PTR(var, &var)` (as
we would still need the original var's string name in the macro for
the inline assembly `#var(%%rip)`), we should nonetheless be able to
merge both into a single macro with one "var" argument. Specifically,
the only current difference between the macros is the input operand
constraint, and GET_RIP_RELATIVE_PTR()'s constraint will work for
both. I will make this change in v3.
> If we are okay with single macro, maybe rename it to RIP_RELATIVE_PTR().
With the merge into a single macro (and upon thinking about the
macro's behavior), I have a slight preference for
`RIP_RELATIVE_ADDR()` in v3 because it makes it clearer that the macro
behaves like the address-of operator "&" (just guaranteeing the use of
RIP-relative addressing to obtain the address). However, I'm happy to
go with RIP_RELATIVE_PTR() if you feel that's better.
> One other thing: I see you sprinkle casts to for every use of the macros.
> But why? void* can cast to any other pointer without explicit casting.
You're right; the casting is unnecessary. I'll eliminate it in v3. Thanks.
> > On Fri, Jan 12, 2024 at 4:17 AM Kirill A. Shutemov
> > <kirill.shutemov@linux.intel.com> wrote:
> > >
> > > Also, is there any reason why GET_RIP_RELATIVE_PTR() and
> > > PTR_TO_RIP_RELATIVE_PTR() have to be macros? Inline functions would be
> > > cleaner.
> >
> > I used macros because we need to use both the global variable itself
> > and the global variable's string name (obtained via #var in the macro)
> > in the inline assembly. As a secondary reason, the macro also avoids
> > the need to provide separate functions for each type of variable for
> > which we'd like to get RIP-relative pointers (ex: u64, unsigned int,
> > unsigned long, etc.).
>
> If we do it only on pointers, wouldn't void * -> void * be enough?
Only using pointers would indeed eliminate the secondary factor as a
reason to use macros. However, the primary motivation for a macro
would remain: we still need the string name of the variable for the
inline assembly.
next prev parent reply other threads:[~2024-01-16 22:13 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 1:26 [RFC PATCH] x86/sev: x86/sev: enforce PC-relative addressing in clang Kevin Loughlin
2024-01-10 11:45 ` Andi Kleen
2024-01-10 17:14 ` Kevin Loughlin
2024-01-10 17:49 ` Andi Kleen
2024-01-11 22:36 ` [RFC PATCH v2] x86/sev: enforce RIP-relative accesses in early SEV/SME code Kevin Loughlin
2024-01-12 12:17 ` Kirill A. Shutemov
2024-01-12 18:29 ` Kevin Loughlin
2024-01-15 10:12 ` Kirill A. Shutemov
2024-01-16 22:13 ` Kevin Loughlin [this message]
2024-01-15 15:53 ` Tom Lendacky
2024-01-16 23:44 ` Kevin Loughlin
2024-01-15 20:46 ` Borislav Petkov
2024-01-17 0:07 ` Kevin Loughlin
2024-01-17 2:47 ` Hou Wenlong
2024-01-17 10:59 ` Ard Biesheuvel
2024-01-17 11:39 ` Andi Kleen
2024-01-17 11:55 ` Ard Biesheuvel
2024-01-17 13:05 ` Borislav Petkov
2024-01-17 13:38 ` Ard Biesheuvel
2024-01-21 14:12 ` Ard Biesheuvel
2024-01-21 15:37 ` Borislav Petkov
2024-01-21 16:49 ` Ard Biesheuvel
2024-01-21 18:20 ` Borislav Petkov
2024-01-30 22:08 ` [PATCH v3 0/2] x86: enforce and cleanup RIP-relative accesses in early boot code Kevin Loughlin
2024-01-31 14:00 ` Borislav Petkov
2024-01-31 18:16 ` Jacob Xu
2024-01-31 18:29 ` Borislav Petkov
2024-02-03 0:22 ` Kevin Loughlin
2024-02-03 10:15 ` Ard Biesheuvel
2024-02-03 10:19 ` Borislav Petkov
2024-02-03 10:27 ` Ard Biesheuvel
2024-02-03 11:25 ` Borislav Petkov
2024-02-06 15:46 ` [tip: x86/sev] x86/sev: Fix position dependent variable references in startup code tip-bot2 for Ard Biesheuvel
2024-01-30 22:08 ` [PATCH v3 1/2] x86/sev: enforce RIP-relative accesses in early SEV/SME code Kevin Loughlin
2024-01-31 8:20 ` Kirill A. Shutemov
2024-02-02 22:00 ` Kevin Loughlin
2024-02-02 22:47 ` Ard Biesheuvel
2024-02-03 0:11 ` Kevin Loughlin
2024-01-31 13:42 ` Ard Biesheuvel
2024-02-03 0:14 ` Kevin Loughlin
2024-01-30 22:08 ` [PATCH v3 2/2] x86/head64: Replace pointer fixups with RIP_RELATIVE_ADDR() Kevin Loughlin
2024-01-31 8:22 ` Kirill A. Shutemov
2024-02-01 16:38 ` Kevin Loughlin
2024-01-31 15:30 ` Tom Lendacky
2024-01-31 15:36 ` Kirill A. Shutemov
2024-01-10 13:36 ` [RFC PATCH] x86/sev: x86/sev: enforce PC-relative addressing in clang Kirill A. Shutemov
2024-01-10 17:28 ` Kevin Loughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGdbjmLrH_fZMS6pCX5pNKCJ2jLm1xAcJkHv5R4Z7MycvhbR5A@mail.gmail.com \
--to=kevinloughlin@google.com \
--cc=acdunlap@google.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=ashish.kalra@amd.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=brijesh.singh@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=dionnaglaze@google.com \
--cc=dwmw@amazon.co.uk \
--cc=houwenlong.hwl@antgroup.com \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=jacobhxu@google.com \
--cc=jpoimboe@kernel.org \
--cc=jroedel@suse.de \
--cc=justinstitt@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-coco@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=luto@kernel.org \
--cc=michael.roth@amd.com \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pankaj.gupta@amd.com \
--cc=peterz@infradead.org \
--cc=pgonda@google.com \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=sidtelang@google.com \
--cc=srutherford@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=vegard.nossum@oracle.com \
--cc=wangjinchao@xfusion.com \
--cc=x86@kernel.org \
--cc=ytcoode@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).