linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties
@ 2020-02-12 10:46 Johan Hovold
  2020-02-12 11:02 ` Oleksandr Suvorov
  2020-02-17  6:36 ` Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Johan Hovold @ 2020-02-12 10:46 UTC (permalink / raw)
  To: Rob Herring, Shawn Guo, Sascha Hauer
  Cc: Mark Rutland, Pengutronix Kernel Team, Fabio Estevam,
	NXP Linux Team, devicetree, linux-kernel, Johan Hovold,
	Sanchayan Maity, Marcel Ziswiler

The sram-node compatible properties have mistakingly combined the
model-specific string with the generic "mtd-ram" string.

Note that neither "cy7c1019dv33-10zsxi, mtd-ram" or
"cy7c1019dv33-10zsxi" are used by any in-kernel driver and they are
not present in any binding.

The physmap driver will however bind to platform devices that specify
"mtd-ram".

Fixes: fc48e76489fd ("ARM: dts: imx6: Add support for Toradex Colibri iMX6 module")
Cc: Sanchayan Maity <maitysanchayan@gmail.com>
Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
index cd075621de52..84fcc203a2e4 100644
--- a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
+++ b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
@@ -275,7 +275,7 @@ &weim {
 
 	/* SRAM on Colibri nEXT_CS0 */
 	sram@0,0 {
-		compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
+		compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
 		reg = <0 0 0x00010000>;
 		#address-cells = <1>;
 		#size-cells = <1>;
@@ -286,7 +286,7 @@ sram@0,0 {
 
 	/* SRAM on Colibri nEXT_CS1 */
 	sram@1,0 {
-		compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
+		compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
 		reg = <1 0 0x00010000>;
 		#address-cells = <1>;
 		#size-cells = <1>;
-- 
2.24.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties
  2020-02-12 10:46 [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties Johan Hovold
@ 2020-02-12 11:02 ` Oleksandr Suvorov
  2020-02-17  6:36 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Oleksandr Suvorov @ 2020-02-12 11:02 UTC (permalink / raw)
  To: Johan Hovold
  Cc: Rob Herring, Shawn Guo, Sascha Hauer, Mark Rutland,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	devicetree, linux-kernel, Sanchayan Maity, Marcel Ziswiler

On Wed, Feb 12, 2020 at 12:46 PM Johan Hovold <johan@kernel.org> wrote:
>
> The sram-node compatible properties have mistakingly combined the
> model-specific string with the generic "mtd-ram" string.
>
> Note that neither "cy7c1019dv33-10zsxi, mtd-ram" or
> "cy7c1019dv33-10zsxi" are used by any in-kernel driver and they are
> not present in any binding.
>
> The physmap driver will however bind to platform devices that specify
> "mtd-ram".
>
> Fixes: fc48e76489fd ("ARM: dts: imx6: Add support for Toradex Colibri iMX6 module")
> Cc: Sanchayan Maity <maitysanchayan@gmail.com>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>

> ---
>  arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> index cd075621de52..84fcc203a2e4 100644
> --- a/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> +++ b/arch/arm/boot/dts/imx6dl-colibri-eval-v3.dts
> @@ -275,7 +275,7 @@ &weim {
>
>         /* SRAM on Colibri nEXT_CS0 */
>         sram@0,0 {
> -               compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
> +               compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
>                 reg = <0 0 0x00010000>;
>                 #address-cells = <1>;
>                 #size-cells = <1>;
> @@ -286,7 +286,7 @@ sram@0,0 {
>
>         /* SRAM on Colibri nEXT_CS1 */
>         sram@1,0 {
> -               compatible = "cypress,cy7c1019dv33-10zsxi, mtd-ram";
> +               compatible = "cypress,cy7c1019dv33-10zsxi", "mtd-ram";
>                 reg = <1 0 0x00010000>;
>                 #address-cells = <1>;
>                 #size-cells = <1>;
> --
> 2.24.1
>


--
Best regards

Oleksandr Suvorov
cryosay@gmail.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties
  2020-02-12 10:46 [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties Johan Hovold
  2020-02-12 11:02 ` Oleksandr Suvorov
@ 2020-02-17  6:36 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2020-02-17  6:36 UTC (permalink / raw)
  To: Johan Hovold
  Cc: Rob Herring, Sascha Hauer, Mark Rutland, Pengutronix Kernel Team,
	Fabio Estevam, NXP Linux Team, devicetree, linux-kernel,
	Sanchayan Maity, Marcel Ziswiler

On Wed, Feb 12, 2020 at 11:46:29AM +0100, Johan Hovold wrote:
> The sram-node compatible properties have mistakingly combined the
> model-specific string with the generic "mtd-ram" string.
> 
> Note that neither "cy7c1019dv33-10zsxi, mtd-ram" or
> "cy7c1019dv33-10zsxi" are used by any in-kernel driver and they are
> not present in any binding.
> 
> The physmap driver will however bind to platform devices that specify
> "mtd-ram".
> 
> Fixes: fc48e76489fd ("ARM: dts: imx6: Add support for Toradex Colibri iMX6 module")
> Cc: Sanchayan Maity <maitysanchayan@gmail.com>
> Cc: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-17  6:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-12 10:46 [PATCH] ARM: dts: imx6dl-colibri-eval-v3: fix sram compatible properties Johan Hovold
2020-02-12 11:02 ` Oleksandr Suvorov
2020-02-17  6:36 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).