From: Joachim Eastwood <manabian@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Arnd Bergmann <arnd@arndb.de>, Axel Lin <axel.lin@ingics.com>,
Hans de Goede <hdegoede@redhat.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Lee Jones <lee.jones@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 03/10] reset: lpc18xx: add driver Kconfig option
Date: Wed, 24 Aug 2016 22:32:00 +0200 [thread overview]
Message-ID: <CAGhQ9VzvU+1qzmmy9NeZmJxX7AS1ez6b4qJuq99J_drSpjJOUw@mail.gmail.com> (raw)
In-Reply-To: <1472045342-7434-3-git-send-email-p.zabel@pengutronix.de>
Hi Philipp,
On 24 August 2016 at 15:28, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Visible only if COMPILE_TEST is enabled, this allows to include the
> driver in build tests.
>
> Cc: Joachim Eastwood <manabian@gmail.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/reset/Kconfig | 7 +++++++
> drivers/reset/Makefile | 2 +-
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> index 1194cbe..8e33de2 100644
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -27,6 +27,13 @@ config RESET_BERLIN
> help
> This enables the reset controller driver for Marvell Berlin SoCs.
>
> +config RESET_LPC18XX
> + bool "LPC18xx/43xx Reset Driver" if COMPILE_TEST
> + default ARCH_LPC18XX
> + help
> + This enables the LPC18xx/43 reset driver that supports the reset
> + controllers on AR71xx SoCs.
Don't know where you got the "AR71xx SoCs" from. This reset controller
is found on NXP LPC18xx/43xx SoCs.
Other than that it looks fine to me.
Acked-by: Joachim Eastwood <manabian@gmail.com>
> +
> config RESET_OXNAS
> bool
>
> diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
> index 34c0b23..25aa05a 100644
> --- a/drivers/reset/Makefile
> +++ b/drivers/reset/Makefile
> @@ -1,5 +1,4 @@
> obj-y += core.o
> -obj-$(CONFIG_ARCH_LPC18XX) += reset-lpc18xx.o
> obj-$(CONFIG_ARCH_SOCFPGA) += reset-socfpga.o
> obj-$(CONFIG_MACH_PISTACHIO) += reset-pistachio.o
> obj-$(CONFIG_ARCH_MESON) += reset-meson.o
> @@ -10,6 +9,7 @@ obj-$(CONFIG_ARCH_HISI) += hisilicon/
> obj-$(CONFIG_ARCH_ZYNQ) += reset-zynq.o
> obj-$(CONFIG_RESET_ATH79) += reset-ath79.o
> obj-$(CONFIG_RESET_BERLIN) += reset-berlin.o
> +obj-$(CONFIG_RESET_LPC18XX) += reset-lpc18xx.o
> obj-$(CONFIG_RESET_OXNAS) += reset-oxnas.o
> obj-$(CONFIG_TI_SYSCON_RESET) += reset-ti-syscon.o
> obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
> --
> 2.8.1
regards,
Joachim Eastwood
next prev parent reply other threads:[~2016-08-24 20:43 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 13:28 [PATCH 01/10] reset: ath79: add driver Kconfig option Philipp Zabel
2016-08-24 13:28 ` [PATCH 02/10] reset: berlin: " Philipp Zabel
2016-08-24 17:43 ` Masahiro Yamada
2016-08-24 13:28 ` [PATCH 03/10] reset: lpc18xx: " Philipp Zabel
2016-08-24 17:43 ` Masahiro Yamada
2016-08-24 20:32 ` Joachim Eastwood [this message]
2016-08-25 7:22 ` Philipp Zabel
2016-08-24 13:28 ` [PATCH 04/10] reset: meson: " Philipp Zabel
2016-08-24 13:30 ` Neil Armstrong
2016-08-24 17:43 ` Masahiro Yamada
2016-08-24 13:28 ` [PATCH 05/10] reset: pistachio: " Philipp Zabel
2016-08-24 17:44 ` Masahiro Yamada
2016-08-29 20:40 ` James Hartley
2016-08-24 13:28 ` [PATCH 06/10] reset: socfpga: " Philipp Zabel
2016-08-24 15:26 ` Dinh Nguyen
2016-08-25 7:23 ` Philipp Zabel
2016-08-24 17:44 ` Masahiro Yamada
2016-08-24 13:28 ` [PATCH 07/10] reset: stm32: " Philipp Zabel
2016-08-24 17:44 ` Masahiro Yamada
2016-08-24 13:29 ` [PATCH 08/10] reset: sunxi: " Philipp Zabel
2016-08-24 17:45 ` Masahiro Yamada
2016-08-24 13:29 ` [PATCH 09/10] reset: zynq: " Philipp Zabel
2016-08-24 17:48 ` Masahiro Yamada
2016-08-25 1:08 ` Masahiro Yamada
2016-08-25 7:23 ` Philipp Zabel
2016-08-25 7:31 ` Masahiro Yamada
2016-08-25 7:51 ` Philipp Zabel
2016-08-24 13:29 ` [PATCH 10/10] reset: hi6220: allow to compile test driver on other architectures Philipp Zabel
2016-08-24 18:00 ` Masahiro Yamada
2016-08-25 7:23 ` Philipp Zabel
2016-08-24 15:51 ` [PATCH 01/10] reset: ath79: add driver Kconfig option Arnd Bergmann
2016-08-24 18:18 ` Masahiro Yamada
2016-08-24 20:06 ` Arnd Bergmann
2016-08-25 2:43 ` Masahiro Yamada
2016-08-25 7:22 ` Philipp Zabel
2016-08-25 7:27 ` Masahiro Yamada
2016-08-25 7:51 ` Philipp Zabel
2016-08-24 17:42 ` Masahiro Yamada
2016-08-25 10:31 ` kbuild test robot
2016-08-25 10:50 ` Arnd Bergmann
2016-08-25 10:57 ` Philipp Zabel
2016-08-25 11:10 ` Alban
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGhQ9VzvU+1qzmmy9NeZmJxX7AS1ez6b4qJuq99J_drSpjJOUw@mail.gmail.com \
--to=manabian@gmail.com \
--cc=arnd@arndb.de \
--cc=axel.lin@ingics.com \
--cc=hdegoede@redhat.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=p.zabel@pengutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).