linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Romain Izard <romain.izard.pro@gmail.com>
To: linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Felipe Balbi <balbi@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Romain Izard <romain.izard.pro@gmail.com>
Subject: Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information
Date: Mon, 29 Aug 2016 10:11:34 +0200	[thread overview]
Message-ID: <CAGkQfmMXpZq47CYcUqFOuciQtuOOpt+sOYpfW=MbJfAL_gN1Og@mail.gmail.com> (raw)
In-Reply-To: <1469550106-16067-1-git-send-email-romain.izard.pro@gmail.com>

2016-07-26 18:21 GMT+02:00 Romain Izard <romain.izard.pro@gmail.com>:
> Disabling USB gadget functions configured through configfs is something
> that can happen in normal use cases. Keep the existing log for this type
> of event, but only as information, not as an error.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
>  drivers/usb/gadget/configfs.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index 70cf3477f951..11f3a649d9e5 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>
>                         list_move_tail(&f->list, &cfg->func_list);
>                         if (f->unbind) {
> -                               dev_err(&gi->cdev.gadget->dev, "unbind function"
> -                                               " '%s'/%p\n", f->name, f);
> +                               dev_info(&gi->cdev.gadget->dev,
> +                                        "unbind function '%s'/%p\n",
> +                                        f->name, f);
>                                 f->unbind(c, f);
>                         }
>                 }
> --
> 2.7.4
>

Ping ?

  reply	other threads:[~2016-08-29  8:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26 16:21 [PATCH v1] usb: gadget: configfs: log function unbinding as information Romain Izard
2016-08-29  8:11 ` Romain Izard [this message]
2016-08-29  8:13 ` Felipe Balbi
2016-08-29  8:22   ` Romain Izard
2016-08-29  9:07 ` [PATCH v2] usb: gadget: configfs: log function unbinding as debug Romain Izard
2016-09-07  9:43   ` Romain Izard
2016-09-07 10:44     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGkQfmMXpZq47CYcUqFOuciQtuOOpt+sOYpfW=MbJfAL_gN1Og@mail.gmail.com' \
    --to=romain.izard.pro@gmail.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).