From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753474AbbDCCKs (ORCPT ); Thu, 2 Apr 2015 22:10:48 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:36600 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbbDCCKo (ORCPT ); Thu, 2 Apr 2015 22:10:44 -0400 MIME-Version: 1.0 In-Reply-To: <20150402205852.GI32500@ld-irv-0074> References: <1420566557-19846-1-git-send-email-punnaia@xilinx.com> <20150402205852.GI32500@ld-irv-0074> Date: Fri, 3 Apr 2015 07:40:43 +0530 X-Google-Sender-Auth: 4wvIyIx6x3DkBG79HHnfxBI8o-k Message-ID: Subject: Re: [PATCH v5 2/2] memory: pl353: Add driver for arm pl353 static memory controller From: punnaiah choudary kalluri To: Brian Norris Cc: Punnaiah Choudary Kalluri , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , Kumar Gala , Rob Landley , "michal.simek@xilinx.com" , Grant Likely , "gregkh@linuxfoundation.org" , "jason@lakedaemon.net" , "ezequiel.garcia@free-electrons.com" , Arnd Bergmann , David Woodhouse , "artem.bityutskiy@linux.intel.com" , "Gupta, Pekon" , "jussi.kivilinna@iki.fi" , Alexandre Courbot , "Khoronzhuk, Ivan" , "joern@logfs.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , Punnaiah Choudary Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Brian, This driver has not been reviewed completely. I will address your comments and send next set of patches. Thanks, Punnaiah On Fri, Apr 3, 2015 at 2:28 AM, Brian Norris wrote: > I'm not following the review of the 'memory' portions much, but has this > gotten much review? I was looking at the MTD portions when I noticed an > obvious issue below: > > On Tue, Jan 06, 2015 at 11:19:17PM +0530, Punnaiah Choudary Kalluri wrote: >> Add driver for arm pl353 static memory controller. This controller is >> used in xilinx zynq soc for interfacing the nand and nor/sram memory >> devices. >> >> Signed-off-by: Punnaiah Choudary Kalluri >> --- >> Changes in v5: >> - Added pl353_smc_get_clkrate function, made pl353_smc_set_cycles as public >> API >> - Removed nand timing parameter initialization and moved it to nand driver >> Changes in v4: >> - Modified driver to support multiple instances >> - Used sleep instaed of busywait for delay >> Changes in v3: >> - None >> Changes in v2: >> - Since now the timing parameters are in nano seconds, added logic to convert >> them to the cycles >> --- >> drivers/memory/Kconfig | 6 + >> drivers/memory/Makefile | 1 + >> drivers/memory/pl353-smc.c | 525 ++++++++++++++++++++++++++++++++++++++ >> include/linux/memory/pl353-smc.h | 37 +++ >> 4 files changed, 569 insertions(+), 0 deletions(-) >> create mode 100644 drivers/memory/pl353-smc.c >> create mode 100644 include/linux/memory/pl353-smc.h >> >> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig >> index 6d91c27..9d4880f 100644 >> --- a/drivers/memory/Kconfig >> +++ b/drivers/memory/Kconfig >> @@ -85,4 +85,10 @@ config FSL_IFC >> bool >> depends on FSL_SOC >> >> +config PL353_SMC >> + bool "ARM PL353 Static Memory Controller(SMC) driver" > > Space after 'Controller'. i.e.: > > bool "ARM PL353 Static Memory Controller (SMC) driver" > >> + default y > > We almost definitely don't want this to be 'default y', especially given > that it would then be enabled on all ARM systems. Users could add it > their configuration themselves if they want it, or you might add it to > multi_v7_defconfig. > >> + depends on ARM >> + help >> + This driver is for the ARM PL353 Static Memory Controller(SMC) module. > > Same spacing issue here. > >> endif > > [...] > > Brian