From: Sven Van Asbroeck <thesven73@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@driverdev.osuosl.org
Subject: Re: [PATCH -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO
Date: Tue, 28 May 2019 09:41:40 -0400 [thread overview]
Message-ID: <CAGngYiU=uFjJFEoiHFUr+ab73sJksaTBkfxvQwL1X6WJnhchqw@mail.gmail.com> (raw)
In-Reply-To: <20190528133214.21776-1-yuehaibing@huawei.com>
Hello YueHaibing,
On Tue, May 28, 2019 at 9:33 AM YueHaibing <yuehaibing@huawei.com> wrote:
>
> Fix gcc build error while CONFIG_REGMAP_MMIO is not set
>
> drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function `controller_probe':
> arcx-anybus.c:(.text+0x9d6): undefined reference to `__devm_regmap_init_mmio_clk'
>
> Select REGMAP_MMIO to fix it.
Thank you for noticing this, I appreciate it !
However, when I run this patch through the scripts/checkpatch.pl
script, it reports
some issues. Could you fix and post v2 please?
checkpatch.pl output follows:
WARNING: Possible unwrapped commit description (prefer a maximum 75
chars per line)
#68:
arcx-anybus.c:(.text+0x9d6): undefined reference to
`__devm_regmap_init_mmio_clk'
ERROR: DOS line endings
#87: FILE: drivers/staging/fieldbus/anybuss/Kconfig:17:
+^Iselect REGMAP_MMIO^M$
total: 1 errors, 1 warnings, 0 checks, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Your patch has style problems, please review.
next prev parent reply other threads:[~2019-05-28 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 13:32 [PATCH -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO YueHaibing
2019-05-28 13:41 ` Sven Van Asbroeck [this message]
2019-05-28 14:10 ` YueHaibing
2019-05-28 14:29 ` [PATCH v2 " YueHaibing
2019-05-28 14:35 ` Sven Van Asbroeck
2019-05-28 15:41 ` YueHaibing
2019-05-28 15:59 ` Greg KH
2019-05-28 17:31 ` Sven Van Asbroeck
2019-06-10 12:51 ` Sven Van Asbroeck
2019-06-10 14:09 ` Greg KH
2019-05-28 14:36 ` YueHaibing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGngYiU=uFjJFEoiHFUr+ab73sJksaTBkfxvQwL1X6WJnhchqw@mail.gmail.com' \
--to=thesven73@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).