From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D5FAC43215 for ; Tue, 19 Nov 2019 20:22:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 773692235D for ; Tue, 19 Nov 2019 20:22:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RNYBUFvV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727239AbfKSUWj (ORCPT ); Tue, 19 Nov 2019 15:22:39 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:37667 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726722AbfKSUWj (ORCPT ); Tue, 19 Nov 2019 15:22:39 -0500 Received: by mail-oi1-f193.google.com with SMTP id y194so20281093oie.4; Tue, 19 Nov 2019 12:22:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EaTTkxHDmEcbt3U07gxobyJb6+sGwOBuoJv50bL/JxA=; b=RNYBUFvVJbWTpntO45DEDvG9rS5TKy6ZiEJVDCOo9tUG3s9Hz7h0Ve3T76zsFtyBNb 1Hi5fdwg9mlhLGNCYbvu//6ptLxjVt5/cZSw/aaA7jZALCUCXnNiYE7AVny+LpCVy9k8 LZB4SAQra2BE09vc5/a2VyQ6dTlLaEfZHBVBNKLXSD7P2BtY+bKNeJwK94GhSC9eEkla 8ej+cQXGIjG8Owe9M1Tq2EPKbO45KhhMQsy8KLl78dm/8NvkediEjAxSePPJ4p8WFAU6 iAX3bI0IF87KXPnV4tTHcP0OkN0Fb/iu1ZPGXGZfgEF6mJE/HnZtcdmnF3EhDoxc6Suy GlAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EaTTkxHDmEcbt3U07gxobyJb6+sGwOBuoJv50bL/JxA=; b=suTtKMO+Z9m0BEMQYrCKjYiNriQ6fI0CckoJPifVpOMtUPUIKXiJpez92q07r1m3kE B6ZoRel6GH3Ag+npTz2/3Pm60Yp8O2D7pFuBl1mgKkZ6JgKQRy6XcAUwOaFfEQ1acH3z LFzHqXnsD/GyfdsOHLxDiShBDDkyAEmLFwk0Zbcj6pBDDL+RJfV6a82bufoQX4ApD3Vq rF7a8STXMN4proWDwbqw7jDV5hY9xcdBUbmErWSBbmbkLYTL7iFsQoq/2wfgMlfoEjPi 3PlFRhsrxtL5RfAiJ0i7UlvtsZNV2C7qLXFr6ApYmwzwWZNV6TiGVWk1dLgtvbqe7AUK QFjA== X-Gm-Message-State: APjAAAUS1h9Sqc1W9UvlNKzb/GLFNsG8NEFazHGh06V2BFsEun/BZMno m5P2NFShYWuj6hbV2NoNRmjc8LaO/ei3OpCJgvc= X-Google-Smtp-Source: APXvYqw9UESCyKM+zUzYQlWNuuB5qfg03HMHFwEnI6OGKoFwxweBxCdAijIYWCJnQxNu51CFhAfe+j5UnT4j/aOpx1Q= X-Received: by 2002:aca:4c57:: with SMTP id z84mr5651946oia.92.1574194956618; Tue, 19 Nov 2019 12:22:36 -0800 (PST) MIME-Version: 1.0 References: <20191119154611.29625-1-TheSven73@gmail.com> <20191119154611.29625-5-TheSven73@gmail.com> In-Reply-To: From: Sven Van Asbroeck Date: Tue, 19 Nov 2019 15:22:25 -0500 Message-ID: Subject: Re: [PATCH v2 4/4] dt-bindings: mfd: update TI tps6105x chip bindings To: Jacek Anaszewski Cc: Dan Murphy , Lee Jones , Liam Girdwood , Mark Brown , Pavel Machek , Rob Herring , Linus Walleij , Grigoryev Denis , Axel Lin , Mark Rutland , devicetree , Linux Kernel Mailing List , linux-leds@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 19, 2019 at 2:38 PM Jacek Anaszewski wrote: > > label DT property was recently deprecated. We now encourage using > 'function' and/or 'color'. Please refer to > Documentation/devicetree/bindings/leds/common.txt. Ah, I see. I'm actually back-porting this from a 4.19 vendor kernel, which I believe does not have function/color support. If I introduce it here, I wouldn't be able to test it easily, and I'd have to forward/back-port. All I need is a single led in the system. So I'll just remove the 'label' code/description, and hard-code the led name to 'tps6105x'. If anyone wants to use this driver and wants named leds, they can always add it themselves. Jacek and Dan, does that satisfy your concerns?