From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753031AbdLAPUo (ORCPT ); Fri, 1 Dec 2017 10:20:44 -0500 Received: from mail-it0-f66.google.com ([209.85.214.66]:44347 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752123AbdLAPUm (ORCPT ); Fri, 1 Dec 2017 10:20:42 -0500 X-Google-Smtp-Source: AGs4zMZyhqBRPndpOs+EGO03CstULUzDCLKPicESYxPZ4l3UhYU2ON94qXBT2Tu9uPG7zVRIPKQ+qA1zmR1LsIBlejE= MIME-Version: 1.0 In-Reply-To: <20171130223524.31716-1-sakari.ailus@linux.intel.com> References: <1512068603-12378-1-git-send-email-svendev@arcx.com> <20171130223524.31716-1-sakari.ailus@linux.intel.com> From: Sven Van Asbroeck Date: Fri, 1 Dec 2017 10:20:41 -0500 Message-ID: Subject: =?UTF-8?Q?Re=3A_=5BPATCH_1=2F1=5D_at24=3A_Fix_I=C2=B2C_device_selection_for_?= =?UTF-8?Q?runtime_PM?= To: Sakari Ailus Cc: linux-i2c@vger.kernel.org, svendev@arcx.com, linux-kernel@vger.kernel.org, divagar.mohandass@intel.com, brgl@bgdev.pl Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank you, it fixes the issue on the multi-address eeprom that I have access to. Tested-by: Sven Van Asbroeck on a 24AA16/24LC16B One very minor remark: + struct device *dev = &at24->client[0]->dev; It is sufficiently clear to others (and us a few months down the line) why we are using only client[0] for power management? Could it benefit from a separate function with comments? struct device *dev = get_pm_device(at24); static struct device *get_pm_device(struct at24_data *at24) { /* explain why we use client[0] and not any of the dummies */ return &at24->client[0]->dev; }