From: Sven Van Asbroeck <thesven73@gmail.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: sound/soc/codecs/zl38060.c:614:34: warning: unused variable 'zl38_dt_ids'
Date: Sat, 11 Jul 2020 11:08:24 -0400 [thread overview]
Message-ID: <CAGngYiXBdT1jOwRS_A03iQiGRbcpPncBxtVOsnFpmauO4ffS5A@mail.gmail.com> (raw)
In-Reply-To: <20200711033036.GA4486@Ryzen-9-3900X.localdomain>
Hi Nathan and Mark,
On Fri, Jul 10, 2020 at 11:30 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> Sure, you could hide it behind an ifdef for either CONFIG_OF or MODULE
> (since you could build this as a module with CONFIG_OF disabled).
>
> I just figured this would be something frowned upon but if that is how
> you would prefer it to be fixed, then I have no objections to it.
>
That's how things used to work in the past: we had to #ifdef CONFIG_OF
all the driver of_XXX code, so it could be built on !CONFIG_OF.
I remember problems with this approach: it generated a lot of
visual noise, it was fragile in both directions: including too much,
and excluding too much. Last but not least, it required us ARM people
to test build each patch on !CONFIG_OF, which many conveniently forgot
to do :)
My "vote" would be to fix the warning using compiler magic. For
example:
#if !CONFIG_OF
// #define of_match_ptr(x) NULL
#define of_match_ptr(x) ((x) == NULL ? NULL : NULL)
#endif
That seems to eliminate the warning on my gcc version 7.5.0, but of
course as compilers get more clever, this could eventually
generate a warning (if it doesn't already on clang).
So perhaps use compiler attributes instead?
Stand-alone testable code snippet below.
======================================================
// gcc -Wall unused.c
// results in: match_table is NULL
// gcc -Wall -DCONFIG_OF unused.c
// results in: match_table[0] = 5
#include <stdio.h>
#ifdef CONFIG_OF
#define of_match_ptr(x) x
#else
#define of_match_ptr(x) ((x) == NULL ? NULL : NULL)
#endif
struct of_device_id {
int id;
};
static const struct of_device_id some_ids[] = {
{ .id = 5, },
{ /* sentinel */ }
};
struct driver {
const struct of_device_id *of_match_table;
};
static const struct driver my_driver = {
.of_match_table = of_match_ptr(some_ids),
};
int main()
{
if (my_driver.of_match_table)
printf("match_table[0] = %d\n", my_driver.of_match_table[0].id);
else
printf("match_table is NULL\n");
}
next prev parent reply other threads:[~2020-07-11 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 16:47 sound/soc/codecs/zl38060.c:614:34: warning: unused variable 'zl38_dt_ids' kernel test robot
2020-07-10 2:41 ` Nathan Chancellor
2020-07-10 12:24 ` Mark Brown
2020-07-11 3:30 ` Nathan Chancellor
2020-07-11 15:08 ` Sven Van Asbroeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-06 5:42 kernel test robot
2020-10-12 19:17 kernel test robot
2020-09-19 17:56 kernel test robot
2020-07-06 2:49 kernel test robot
2020-06-17 8:43 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGngYiXBdT1jOwRS_A03iQiGRbcpPncBxtVOsnFpmauO4ffS5A@mail.gmail.com \
--to=thesven73@gmail.com \
--cc=broonie@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).