From: Sven Van Asbroeck <thesven73@gmail.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Lukas Wunner <lukas@wunner.de>, Mark Brown <broonie@kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>,
Andreas Kemnade <andreas@kemnade.info>
Subject: Re: [BUG] SPI broken for SPI based panel drivers
Date: Fri, 4 Dec 2020 14:19:11 -0500 [thread overview]
Message-ID: <CAGngYiXWKgu+RKvbUWCSy2pDktc8Uj6+PtWi0oc8tAgiDgoUFw@mail.gmail.com> (raw)
In-Reply-To: <7702A943-FCC5-416B-B53A-3B0427458915@goldelico.com>
On Fri, Dec 4, 2020 at 11:52 AM H. Nikolaus Schaller <hns@goldelico.com> wrote:
>
> >> Anyways it is debatable if this is a bug at all. It is just a definition.
> >
> > I respectfully disagree. Prior to the fix, your panel's active-low chip select
> > needed to be described in the devicetree with 'spi-cs-high'. That sounds
> > very much like a bug to me.
>
> It could have been described by ACTIVE_LOW without spi-cs-high but that did
> emit a nasty and not helpful warning on each boot.
That will not work, try it out. You will see that without the bugfix, your chip
select is consistently inverted, no matter how you formulate it in the
devicetree.
>
> I'd prefer if you or maybe Linus could submit such a patch and I am happy to review it.
I cannot help you with that, I'm sorry.
next prev parent reply other threads:[~2020-12-04 19:20 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 19:03 [BUG] SPI broken for SPI based panel drivers H. Nikolaus Schaller
2020-11-30 20:13 ` Sven Van Asbroeck
2020-11-30 20:22 ` Sven Van Asbroeck
2020-12-01 8:59 ` H. Nikolaus Schaller
2020-12-01 12:16 ` Mark Brown
2020-12-01 14:05 ` H. Nikolaus Schaller
2020-12-01 14:20 ` Linus Walleij
2020-12-01 14:34 ` Sven Van Asbroeck
2020-12-01 14:35 ` H. Nikolaus Schaller
2020-12-01 15:52 ` Sven Van Asbroeck
2020-12-01 16:46 ` H. Nikolaus Schaller
2020-12-01 16:10 ` Sven Van Asbroeck
2020-12-01 16:39 ` H. Nikolaus Schaller
2020-12-01 16:53 ` Sven Van Asbroeck
2020-12-01 17:10 ` H. Nikolaus Schaller
2020-12-01 18:43 ` Sven Van Asbroeck
2020-12-02 12:19 ` Mark Brown
2020-12-04 10:08 ` H. Nikolaus Schaller
2020-12-04 13:46 ` Sven Van Asbroeck
2020-12-04 16:49 ` H. Nikolaus Schaller
2020-12-04 19:19 ` Sven Van Asbroeck [this message]
2020-12-04 21:31 ` H. Nikolaus Schaller
2020-12-05 0:25 ` Linus Walleij
2020-12-05 7:04 ` H. Nikolaus Schaller
2020-12-09 8:04 ` Andreas Kemnade
2020-12-09 8:40 ` H. Nikolaus Schaller
2020-12-09 8:38 ` Linus Walleij
2020-12-09 8:45 ` H. Nikolaus Schaller
2020-12-01 22:51 ` Linus Walleij
2020-12-01 16:44 ` [Letux-kernel] " Andreas Kemnade
2020-12-01 16:51 ` H. Nikolaus Schaller
2020-12-01 16:52 ` H. Nikolaus Schaller
2020-12-01 16:55 ` Sven Van Asbroeck
2020-12-01 16:20 ` Mark Brown
2020-12-01 16:41 ` H. Nikolaus Schaller
2020-12-01 17:11 ` Mark Brown
2020-12-01 12:41 ` Sven Van Asbroeck
2020-12-01 13:32 ` H. Nikolaus Schaller
2020-12-01 14:08 ` Sven Van Asbroeck
2020-12-01 15:33 ` Mark Brown
2020-12-05 20:57 ` Pavel Machek
2020-12-07 13:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGngYiXWKgu+RKvbUWCSy2pDktc8Uj6+PtWi0oc8tAgiDgoUFw@mail.gmail.com \
--to=thesven73@gmail.com \
--cc=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=hns@goldelico.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=letux-kernel@openphoenux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).