From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22BBEC433FF for ; Sun, 28 Jul 2019 01:37:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB6E22086D for ; Sun, 28 Jul 2019 01:37:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729085AbfG1BhK (ORCPT ); Sat, 27 Jul 2019 21:37:10 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:33982 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726240AbfG1BhK (ORCPT ); Sat, 27 Jul 2019 21:37:10 -0400 Received: by mail-lj1-f193.google.com with SMTP id p17so55096570ljg.1 for ; Sat, 27 Jul 2019 18:37:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZIqB9c4q6lN44PyPxcoCMV7r219u87AEU3TH3a5CGas=; b=ReCshGPBRPhg8Co0BNPLZT9vREYsGam4cGdaeearjxONFJavZVKf+LhXePnkr6GjDd dv055zQEh7WaubQiWMfbDBSXBVEnE69NjHs8/Dhwhs0Z21WvqAyGsK3+zGsH7eFuvEmy 0puWL/Z5h9AvHLyLF+tTBNS7E8BkvAJxrKO+z2q7SOqFOi5E1EDYpVFJ73irpIhurNAL nvmpBwAhpYhvBoMkvrAgi1/hTRq4UTTF6DVBB8Rly5XNHtjwK9qcek30L+aGHLNXhqlQ /AEnVh3tMutbuoIoehWu91rd+nTcMJBmRa05EvmcNrGREiGzQOT9I3ik+zvyD7F5ak9P 2tyA== X-Gm-Message-State: APjAAAWexsc15sKF4hG6xlol5RxCosVxPAdaPWK6OGwhJk/PLeVyve3g 9wEE2qocSaDhh8vf2PoyovfNysGKCqCkRwCtj597qQ== X-Google-Smtp-Source: APXvYqwGgdIRAVeuQlsulkeErK79fVKFr19G5qlxtgIIKSyN8WnYjQDqWSBRjwvcPslOs0FyyDwk/YkI/IxY5fV3j5U= X-Received: by 2002:a2e:9117:: with SMTP id m23mr53783934ljg.134.1564277828052; Sat, 27 Jul 2019 18:37:08 -0700 (PDT) MIME-Version: 1.0 References: <20190725231546.23878-1-mcroce@redhat.com> <20190726125715.GB5031@kwain> In-Reply-To: <20190726125715.GB5031@kwain> From: Matteo Croce Date: Sun, 28 Jul 2019 03:36:31 +0200 Message-ID: Subject: Re: [PATCH net-next] mvpp2: document HW checksum behaviour To: Antoine Tenart , Marcin Wojtas , Stefan Chulski , Maxime Chevallier Cc: netdev , LKML , "David S . Miller" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 26, 2019 at 2:57 PM Antoine Tenart wrote: > > Hi Matteo, > > On Fri, Jul 26, 2019 at 01:15:46AM +0200, Matteo Croce wrote: > > The hardware can only offload checksum calculation on first port due to > > the Tx FIFO size limitation. Document this in a comment. > > > > Fixes: 576193f2d579 ("net: mvpp2: jumbo frames support") > > Signed-off-by: Matteo Croce > > Looks good. Please note there's a similar code path in the probe. You > could also add a comment there (or move this check/comment in a common > place). > > Thanks! > Antoine > Hi Antoine, I was making a v2, when I looked at the mvpp2_port_probe() which does: --------------------------------%<------------------------------ features = NETIF_F_SG | NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM | NETIF_F_TSO; if (port->pool_long->id == MVPP2_BM_JUMBO && port->id != 0) { dev->features &= ~(NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM); dev->hw_features &= ~(NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM); } dev->vlan_features |= features; -------------------------------->%------------------------------ Is it ok to remove NETIF_F_IP*_CSUM from dev->features and dev->hw_features but keep it in dev->vlan_features? Regards, -- Matteo Croce per aspera ad upstream