From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754193AbcHWSpJ (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 Aug 2016 14:45:09 -0400
Received: from mail-ua0-f195.google.com ([209.85.217.195]:35521 "EHLO
        mail-ua0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753103AbcHWSpH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 Aug 2016 14:45:07 -0400
MIME-Version: 1.0
In-Reply-To: <9a6a8663-a3f7-7875-253f-98232d56b860@ti.com>
References: <20160819225159.10758-1-nm@ti.com> <20160819225159.10758-4-nm@ti.com>
 <9a6a8663-a3f7-7875-253f-98232d56b860@ti.com>
From: Nishanth Menon <nm@ti.com>
Date: Tue, 23 Aug 2016 13:45:05 -0500
X-Google-Sender-Auth: JKe15Zxz-2oBVJyHkAmjsZ4H03A
Message-ID: <CAGo_u6p3Bm+zGDtxpOyT+DeGN8_XPWWE0zhCYuxsH47n41Z8jg@mail.gmail.com>
Subject: Re: [PATCH 3/5] firmware: ti_sci: Add support for Device control
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Santosh Shilimkar <ssantosh@kernel.org>, Tero Kristo <t-kristo@ti.com>,
        Dave Gerlach <d-gerlach@ti.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>, "Andrew F . Davis" <afd@ti.com>,
        dt list <devicetree@vger.kernel.org>, Russ Dill <Russ.Dill@ti.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Aug 21, 2016 at 10:56 PM, Lokesh Vutla <lokeshvutla@ti.com> wrote:
>>  /**
>> + * tis_sci_is_response_ack() - Generic ACK/NACK message checkup
>> + * @r:       pointer to response buffer
>> + *
>> + * Return: true if the response was an ACK, else returns false.
>> + */
>> +static inline bool tis_sci_is_response_ack(void *r)
>
> May be just ti_sci_is_response_ack() to be consistent? or you wanted to
> keep it tis_sci* ?


Uggh.. Fat fingered that one.. thanks for catching.. fixed and will
post a v2 next week if there is no further comments

---
Regards,
Nishanth Menon