From: Nishanth Menon <nm@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tero Kristo <t-kristo@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Dave Gerlach <d-gerlach@ti.com>
Subject: Re: [PATCH] firmware: ti_sci: fix strncat length check
Date: Wed, 11 Jan 2017 08:29:45 -0600 [thread overview]
Message-ID: <CAGo_u6qoQohj6=vsVumOHRiSxviPA2=2aW-zGhQJ9cQPUdzjgw@mail.gmail.com> (raw)
In-Reply-To: <20170111133808.3757036-1-arnd@arndb.de>
On Wed, Jan 11, 2017 at 7:37 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> gcc-7 notices that the length we pass to strncat is wrong:
>
> drivers/firmware/ti_sci.c: In function 'ti_sci_probe':
> drivers/firmware/ti_sci.c:204:32: error: specified bound 50 equals the size of the destination [-Werror=stringop-overflow=]
>
> Instead of the total length, we must pass the length of the
> remaining space here.
>
> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/firmware/ti_sci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 874ff32db366..00cfed3c3e1a 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -202,7 +202,8 @@ static int ti_sci_debugfs_create(struct platform_device *pdev,
> info->debug_buffer[info->debug_region_size] = 0;
>
> info->d = debugfs_create_file(strncat(debug_name, dev_name(dev),
> - sizeof(debug_name)),
> + sizeof(debug_name) -
> + sizeof("ti_sci_debug@")),
> 0444, NULL, info, &ti_sci_debug_fops);
> if (IS_ERR(info->d))
> return PTR_ERR(info->d);
Aargh.. thanks.... Santosh: if you could pick this up.. using
strlen(debug_name) might be an overkill here.
Acked-by: Nishanth Menon <nm@ti.com>
---
Regards,
Nishanth Menon
next prev parent reply other threads:[~2017-01-11 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 13:37 [PATCH] firmware: ti_sci: fix strncat length check Arnd Bergmann
2017-01-11 14:29 ` Nishanth Menon [this message]
2017-03-14 21:11 Arnd Bergmann
2017-03-14 21:19 ` santosh.shilimkar
2017-05-19 8:32 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGo_u6qoQohj6=vsVumOHRiSxviPA2=2aW-zGhQJ9cQPUdzjgw@mail.gmail.com' \
--to=nm@ti.com \
--cc=arnd@arndb.de \
--cc=d-gerlach@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).