On Tue 9 Jan, 2018, 10:32 PM Greg Kroah-Hartman, wrote: > On Fri, Dec 22, 2017 at 07:37:03PM +0530, Harsh Shandilya wrote: > > From: Harsh Shandilya > > > > Several methods in the driver were hardcoding > > the function name in their logging calls which > > is a checkpatch violation. Utilise the __func__ > > macro to avoid needing to add the function name > > as is to the string. > > > > Test: logtags in dmesg remain unaffected before > > and after the patch. > > > > Signed-off-by: Harsh Shandilya > > > > Cc: Greg Kroah-Hartman > > Cc: "Arve Hjønnevåg" > > Cc: Todd Kjos > > Cc: Martijn Coenen > > Cc: devel@driverdev.osuosl.org > > Cc: linux-kernel@vger.kernel.org > > --- > > drivers/android/binder.c | 13 +++++++------ > > 1 file changed, 7 insertions(+), 6 deletions(-) > > Patch does not apply to my tree :( > If you drop https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/commit/?h=char-misc-next&id=00c41cddebde8d1a635bf81a7b255b7e56fd0d15 then the patch should go in cleanly. My patch includes the changes from Elad's already. P.S. sorry about the derp with the email earlier, I didn't realise I used "Reply" in place of "Reply all". Will take care henceforth. >