From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1515527144; cv=none; d=google.com; s=arc-20160816; b=f5YthQNDO7q5IUJPX1AE/nQVBQ2Kh1vzNGD1clWR4inwNeAVx7qeGWwtNtpo4e0Ff1 glAZVtI1A2Cei8Zvn2LTMqU/96HbHc03WIXHu/pxO+RMtDylVDabIG/G2P/1XQ3XLVq6 CP7gQYNKSwW1qJOId/zoODuomEp02xR3CAZLLc0ZMUtk7zuC8LPqfhpFAZo4FPhKiy93 V4MwKaitImeJpdYXKbEB0ROqQsKrrUbTODfOclkiH4VVhZ+6AbPfVQkRbHOipSPUT52i 22xJRSHc/OSAEEZIazS7UBV+V70LNhQ348pthmhkyrCVOOJZryNAhsU9zZNfkPSAyf0b CJjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature:arc-authentication-results; bh=4Sme9F6VB17dnZkXXUlm5Gq18eth0zP5exxVs2qmC6k=; b=vkn/DKMpr3a3ZgGCzJzRlLC778sUPSBjq7TV6KbX2q5kWgT9cFk8SH7SprhMKo5aCC TCLdbnw6I4jeX5qBWDLqGNWTGIn0Pl4z0Xr27iSrYpDT/56IoeFzbgJI3/aVqxZ/xoU5 AKsYDRgFEfnkumGHaBikSxjiwrIPpBsd3FHa0o0JEMY4L/uj0ykUJ/kaHV2eb6eWA88g wADM8moUuSaqVPSF2c1y4Ampir+c00xzYWcB/hFeSMyzM1wS2uas8zT4d24JE6F74UQI akvQwyg9MRskEj5qqpLXLMPqIMwlTKWzlnNEkqbKCkjwddCWAwp2hDxLfCCjwHuZFckT jWFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@prjkt-io.20150623.gappssmtp.com header.s=20150623 header.b=sFrBYUmp; spf=neutral (google.com: 209.85.220.65 is neither permitted nor denied by best guess record for domain of harsh@prjkt.io) smtp.mailfrom=harsh@prjkt.io Authentication-Results: mx.google.com; dkim=pass header.i=@prjkt-io.20150623.gappssmtp.com header.s=20150623 header.b=sFrBYUmp; spf=neutral (google.com: 209.85.220.65 is neither permitted nor denied by best guess record for domain of harsh@prjkt.io) smtp.mailfrom=harsh@prjkt.io X-Google-Smtp-Source: ACJfBot9mKbJ3QIlm0hPTu3brmJZO78qusSZpq1wwRdDZWzVMbGQ4x8kjtaIW81QplMDFfnUZ0MPfAR5Fb3pCAsMu8w= MIME-Version: 1.0 References: <20171222140703.21235-1-msfjarvis@gmail.com> <20171222140703.21235-2-msfjarvis@gmail.com> <20180109170214.GA16149@kroah.com> In-Reply-To: <20180109170214.GA16149@kroah.com> From: Harsh Shandilya Date: Tue, 09 Jan 2018 19:45:33 +0000 Message-ID: Subject: Re: [PATCH 2/2] drivers: android: Fix logtags in methods To: Greg Kroah-Hartman Cc: =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Harsh Shandilya , Martijn Coenen , Todd Kjos , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: multipart/alternative; boundary="001a113e3c700c350205625d29a9" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1587493407785946106?= X-GMAIL-MSGID: =?utf-8?q?1589145390582827895?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: --001a113e3c700c350205625d29a9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue 9 Jan, 2018, 10:32 PM Greg Kroah-Hartman, wrote: > On Fri, Dec 22, 2017 at 07:37:03PM +0530, Harsh Shandilya wrote: > > From: Harsh Shandilya > > > > Several methods in the driver were hardcoding > > the function name in their logging calls which > > is a checkpatch violation. Utilise the __func__ > > macro to avoid needing to add the function name > > as is to the string. > > > > Test: logtags in dmesg remain unaffected before > > and after the patch. > > > > Signed-off-by: Harsh Shandilya > > > > Cc: Greg Kroah-Hartman > > Cc: "Arve Hj=C3=B8nnev=C3=A5g" > > Cc: Todd Kjos > > Cc: Martijn Coenen > > Cc: devel@driverdev.osuosl.org > > Cc: linux-kernel@vger.kernel.org > > --- > > drivers/android/binder.c | 13 +++++++------ > > 1 file changed, 7 insertions(+), 6 deletions(-) > > Patch does not apply to my tree :( > If you drop https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/commit= /?h=3Dchar-misc-next&id=3D00c41cddebde8d1a635bf81a7b255b7e56fd0d15 then the patch should go in cleanly. My patch includes the changes from Elad's already. P.S. sorry about the derp with the email earlier, I didn't realise I used "Reply" in place of "Reply all". Will take care henceforth. > --001a113e3c700c350205625d29a9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tue 9 Jan, 2018, 10:= 32 PM Greg Kroah-Hartman, <gregkh@linuxfoundation.org> wrote:
On Fri, Dec 22, 2017 at 07:37:03PM +0530, Harsh Shandilya wrote: > From: Harsh Shandilya <harsh@prjkt.io>
>
> Several methods in the driver were hardcoding
> the function name in their logging calls which
> is a checkpatch violation. Utilise the __func__
> macro to avoid needing to add the function name
> as is to the string.
>
> Test: logtags in dmesg remain unaffected before
> and after the patch.
>
> Signed-off-by: Harsh Shandilya <harsh@prjkt.io>
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Arve Hj=C3=B8nnev=C3=A5g" <arve@android.com>
> Cc: Todd Kjos <tkjos@android.com>
> Cc: Martijn Coenen <maco@android.com>
> Cc: de= vel@driverdev.osuosl.org
> Cc: = linux-kernel@vger.kernel.org
> ---
>=C2=A0 drivers/android/binder.c | 13 +++++++------
>=C2=A0 1 file changed, 7 insertions(+), 6 deletions(-)

Patch does not apply to my tree :(

If you drop https://git.kernel.org/pub/scm/linux/kernel/git/gregk= h/char-misc.git/commit/?h=3Dchar-misc-next&id=3D00c41cddebde8d1a635bf81= a7b255b7e56fd0d15 then the patch should go in cleanly. My patch include= s the changes from Elad's already.

P.S. so= rry about the derp with the email earlier, I didn't realise I used &quo= t;Reply" in place of "Reply all". Will take care henceforth.=
--001a113e3c700c350205625d29a9--