From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753733AbbIUJVe (ORCPT ); Mon, 21 Sep 2015 05:21:34 -0400 Received: from mail-la0-f43.google.com ([209.85.215.43]:32882 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751903AbbIUJVd (ORCPT ); Mon, 21 Sep 2015 05:21:33 -0400 MIME-Version: 1.0 In-Reply-To: <1442597788-4306-1-git-send-email-eu@felipetonello.com> References: <1442597788-4306-1-git-send-email-eu@felipetonello.com> Date: Mon, 21 Sep 2015 10:21:31 +0100 Message-ID: Subject: Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue From: Felipe Tonello To: USB list Cc: Kernel development list , Peter Chen , Greg Kroah-Hartman , Felipe Balbi , Andrzej Pietrasiewicz , "Felipe F. Tonello" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Balbi, On Fri, Sep 18, 2015 at 6:36 PM, wrote: > From: "Felipe F. Tonello" > > f_midi is not checking whether there is an error on usb_ep_queue > request, ignoring potential problems, such as memory leaks. > > Signed-off-by: Felipe F. Tonello > --- > > Changes for v2: > - Update code style. > > Changes for v3: > - Use ip_ep instead of out_ep. Fixed typo in commit message. I forgot to add v3 to the patch subject, so it queued here instead. Do you want me to re-send as v3? Felipe Tonello