From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D2DC433FE for ; Thu, 7 Oct 2021 10:30:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A82D060C4C for ; Thu, 7 Oct 2021 10:30:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240864AbhJGKcv (ORCPT ); Thu, 7 Oct 2021 06:32:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240726AbhJGKcs (ORCPT ); Thu, 7 Oct 2021 06:32:48 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FDC6C061746; Thu, 7 Oct 2021 03:30:54 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id v18so21287029edc.11; Thu, 07 Oct 2021 03:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8mY64fv5z2ogFhndQ+OIlGH9TZ8lF/cAOTOOGKeTfLw=; b=IV75uUEO7ve3jcFTQQ6a0Hr/G1GyiMzZzVnGSB7EfvQMJ5tIWrRC4wF6dETgBP4aDw l26+4R5zB9K6adNvVf9SVfyBAsgFP8lbqeUHJvfvuAYiSSQkwm8m+SkeHYD8tHk5mup5 SaK99WGZ+f09FzfaOoX3ifT96Zb3j0QaIBe9rUIRX/GusHmqapUI5FCmZn9gZ6fFbPV8 DNU0yTuvia/M83FHOsFokMOfUvhxRoWNmwhtlYgaPrqhnIoV/hb+sg3gao2eWTy5A82D xo5dZHxTHTL/hajBtitEialaqAsDyE/gPdPJOPq7XAeaU9sykqpOHKixZnA/Ac++g4nu LgLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8mY64fv5z2ogFhndQ+OIlGH9TZ8lF/cAOTOOGKeTfLw=; b=PAKVYZ2jjv7k56TgDOpyLUGobPHlbvqISxfKh2j3MSWwfHK57V/2cS7TKW7FZVCywq iGRKz3tUcmpxhJJtcucy0R03oORjFy/sDcESdiPF06MdI6NgyMe0bxCB67FFg5aakTD1 BBodVpFvwaQAkQevqc0hGtpxFhQx0CVPNryevet2JER2QZB0uzssUyveNybA/0HcZXZX FxVd8tGG+Z2ummwHGoNoYlwHattkB7hd7Me/iB5/oaOpvRlFr3ey6SAZP8Hphxkzdbls LlID424mxP42r/VhThMzW5CXkaxovmQDsdc1vy9zD0AUqLtj4ugQKuqxXnlR/QNXMXjU o8yA== X-Gm-Message-State: AOAM532KB3vP5LaTqmMgZyK14lzWZC1BDuYP1RW+cgm4dkzxE1bAf8in kvGKOtI6KA24Fk2KgkMAUbRttMZQ9tKiJtluk8A= X-Google-Smtp-Source: ABdhPJzrxcI8+MEuid+j/nPlF6m0fxTDB9iXiOL8Z0cef8F4m1dbX18KPjmL0x/le3rVHgOioxp/v891RcG75XEOdZA= X-Received: by 2002:a17:906:3383:: with SMTP id v3mr4674165eja.213.1633602648062; Thu, 07 Oct 2021 03:30:48 -0700 (PDT) MIME-Version: 1.0 References: <20210924085104.44806-1-21cnbao@gmail.com> <20210924085104.44806-2-21cnbao@gmail.com> <87o883l9c8.mognet@arm.com> <20211006121858.GI174703@worktop.programming.kicks-ass.net> <20211006135550.GJ174703@worktop.programming.kicks-ass.net> In-Reply-To: <20211006135550.GJ174703@worktop.programming.kicks-ass.net> From: Barry Song <21cnbao@gmail.com> Date: Thu, 7 Oct 2021 23:30:36 +1300 Message-ID: Subject: Re: [PATCH RESEND 1/3] topology: Represent clusters of CPUs within a die To: Peter Zijlstra Cc: Valentin Schneider , Dietmar Eggemann , LKML , Ingo Molnar , Vincent Guittot , Aubrey Li , Borislav Petkov , Daniel Bristot de Oliveira , Ben Segall , Catalin Marinas , Greg Kroah-Hartman , Guodong Xu , "H. Peter Anvin" , Jonathan Cameron , Juri Lelli , "Cc: Len Brown" , ACPI Devel Maling List , LAK , Linuxarm , Mark Rutland , Mel Gorman , msys.mizuma@gmail.com, "Zengtao (B)" , "Rafael J. Wysocki" , Steven Rostedt , Barry Song , Sudeep Holla , Thomas Gleixner , "Rafael J. Wysocki" , Tim Chen , Will Deacon , x86 , yangyicong , Tian Tao Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 7, 2021 at 2:55 AM Peter Zijlstra wrote: > > On Thu, Oct 07, 2021 at 01:50:43AM +1300, Barry Song wrote: > > On Thu, Oct 7, 2021 at 1:20 AM Peter Zijlstra wrote: > > > > > > On Wed, Oct 06, 2021 at 11:50:35PM +1300, Barry Song wrote: > > > > > > > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > > > > > index 7cb31d959f33..fc0836f460fb 100644 > > > > > --- a/drivers/base/arch_topology.c > > > > > +++ b/drivers/base/arch_topology.c > > > > > @@ -622,7 +622,8 @@ void update_siblings_masks(unsigned int cpuid) > > > > > if (cpuid_topo->package_id != cpu_topo->package_id) > > > > > continue; > > > > > > > > > > - if (cpuid_topo->cluster_id == cpu_topo->cluster_id) { > > > > > + if (cpuid_topo->cluster_id == cpu_topo->cluster_id && > > > > > + cpuid_topo->cluster_id != -1) { > > > > > cpumask_set_cpu(cpu, &cpuid_topo->cluster_sibling); > > > > > cpumask_set_cpu(cpuid, &cpu_topo->cluster_sibling); > > > > > } > > > > > > > > > > > > > Hi Peter, > > > > Would you like to change this line in your tree? > > > > > > Can you please double check: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=sched/next > > > > yes. It is correct for patch 1/3, thanks! oops, there is a typo there: + if (cpuid_topo->cluster_id == cpu_topo->cluster_id && + cpuid_topo->clister_id != -1) { clister should be cluster. > > > > BTW, patch2/3 is missing some benchmark data and tested-by/SOB tags, i guess > > it is because you are still editing? > > Urgh, no, that's my script thinking one of the many > > -------------- > > lines you got in there was a terminator. Fixed it, should be pushed out > again in a few minutes. Thanks barry