From: Barry Song <baohua@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Barry Song <Baohua.Song@csr.com>,
Linux GPIO List <linux-gpio@vger.kernel.org>,
DL-SHA-WorkGroupLinux <workgroup.linux@csr.com>
Subject: Re: [PATCH 1/2] RFT: pinctrl: sirf: switch to using allocated state container
Date: Sun, 25 May 2014 16:26:53 +0800 [thread overview]
Message-ID: <CAGsJ_4ygjo_cUFR8bUoWsGrZYHSubam4WWcb-TjQJNjgy9rvKQ@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdbieXh8iHSCqai03vNbBZ2_2zV1SscXLY+4T9ZprWJEvQ@mail.gmail.com>
2014-05-09 19:53 GMT+08:00 Linus Walleij <linus.walleij@linaro.org>:
> On Thu, May 1, 2014 at 2:29 PM, Barry Song <baohua@kernel.org> wrote:
>> 2014-04-24 5:16 GMT+08:00 Linus Walleij <linus.walleij@linaro.org>:
>
>>> This rewrites the SIRF pinctrl driver to allocate a state container
>>> for the GPIO chip, just as is done for the pin controller, and
>>> use the gpiochip_add_pin_range() to add the range from the gpiochip
>>> side rather than adding the range from the pinctrl side.
>>>
>>> All resulting changes are done in order to pass around a state
>>> container rather than refer to a static global object.
>>>
>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>
>> Linus, thanks! but this breaks prima2 pinctrl subsystem, do you have an idea?
>> otherwise i will do a debug to find the reason.
>
> Unfortunately no :-(
>
> This is the downside of dry-coding ... I rely on others to help out.
>
> See it as a suggestion to what I think should be refactored and how,
> I'll keep it on a branch as some "TODO" item for the moment.
>
after moving pinctrl name from sirfsoc-gpio* to dev_name(&pdev->dev) as below:
- err = gpiochip_add_pin_range(&sgpio->chip.gc, "sirfsoc-gpio*",
+ err = gpiochip_add_pin_range(&sgpio->chip.gc, dev_name(&pdev->dev),
Acked-by: Barry Song <Baohua.Song@csr.com>
> Yours,
> Linus Walleij
-barry
next prev parent reply other threads:[~2014-05-25 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 21:16 [PATCH 0/2] RTF: pinctrl: sirf: state container refactorings Linus Walleij
2014-04-23 21:16 ` [PATCH 1/2] RFT: pinctrl: sirf: switch to using allocated state container Linus Walleij
2014-05-01 12:29 ` Barry Song
2014-05-09 11:53 ` Linus Walleij
2014-05-25 8:26 ` Barry Song [this message]
2014-05-27 13:27 ` Linus Walleij
2014-05-27 15:10 ` Barry Song
2014-05-28 8:43 ` Linus Walleij
2014-04-23 21:16 ` [PATCH 2/2] RFT: pinctrl: sirf: move sgpio lock into " Linus Walleij
2014-05-01 12:40 ` Barry Song
2014-05-09 11:57 ` Linus Walleij
2014-05-25 7:51 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGsJ_4ygjo_cUFR8bUoWsGrZYHSubam4WWcb-TjQJNjgy9rvKQ@mail.gmail.com \
--to=baohua@kernel.org \
--cc=Baohua.Song@csr.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=workgroup.linux@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).