Re: [PATCH v1 23/28] i2c: sirf: convert to devm_platform_ioremap_resource

From: Barry Song <baohua@kernel.org>
To: Dejin Zheng <zhengdejin5@gmail.com>
Cc: thor.thayer@linux.intel.com, krzysztof.adamski@nokia.com,
	rjui@broadcom.com, sbranden@broadcom.com,
	bcm-kernel-feedback-list@broadcom.com, f.fainelli@gmail.com,
	Sekhar Nori <nsekhar@ti.com>,
	bgolaszewski@baylibre.com, jarkko.nikula@linux.intel.com,
	andriy.shevchenko@linux.intel.com,
	mika.westerberg@linux.intel.com, Baruch Siach <baruch@tkos.co.il>,
	wsa+renesas@sang-engineering.com, kgene@kernel.org,
	krzk@kernel.org, paul@crapouillou.net, vz@mleia.com,
	khilman@baylibre.com, matthias.bgg@gmail.com,
	gregory.clement@bootlin.com, rrichter@marvell.com,
	afaerber@suse.de, manivannan.sadhasivam@linaro.org,
	agross@kernel.org, bjorn.andersson@linaro.org, heiko@sntech.de,
	Linus Walleij <linus.walleij@linaro.org>,
	mripard@kernel.org, wens@csie.org, ardb@kernel.org,
	Michal Simek <michal.simek@xilinx.com>,
	gcherian@marvell.com, jun.nie@linaro.org, shawnguo@kernel.org,
	rayagonda.kokatanur@broadcom.com, lori.hikichi@broadcom.com,
	nishkadg.linux@gmail.com, kstewart@linuxfoundation.org,
	allison@lohutok.net,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	bigeasy@linutronix.de, info@metux.net, hslester96@gmail.com,
	narmstrong@baylibre.com, martin.blumenstingl@googlemail.com,
	qii.wang@mediatek.com, drinkcat@chromium.org,
	hsinyi@chromium.org, fparent@baylibre.com,
	opensource@jilayne.com, swinslow@gmail.com,
	linux-i2c@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 23/28] i2c: sirf: convert to devm_platform_ioremap_resource
Date: Thu, 9 Apr 2020 12:02:58 +1200	[thread overview]
Message-ID: <CAGsJ_4yiQed=kPpKJvHiGYJc0y0-qCmvV5+zYRKvBWJYVKrDog@mail.gmail.com> (raw)
In-Reply-To: <20200407163741.17615-24-zhengdejin5@gmail.com>

Dejin Zheng <zhengdejin5@gmail.com> 于2020年4月8日周三 上午4:39写道：
>
> use devm_platform_ioremap_resource() to simplify code, which
> contains platform_get_resource and devm_ioremap_resource.
>
> Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>

Reviewed-by: Barry Song <baohua@kernel.org>

> ---
>  drivers/i2c/busses/i2c-sirf.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-sirf.c b/drivers/i2c/busses/i2c-sirf.c
> index fb7a046b3226..269a71b0ee7f 100644
> --- a/drivers/i2c/busses/i2c-sirf.c
> +++ b/drivers/i2c/busses/i2c-sirf.c
> @@ -272,7 +272,6 @@ static int i2c_sirfsoc_probe(struct platform_device *pdev)
>  {
>         struct sirfsoc_i2c *siic;
>         struct i2c_adapter *adap;
> -       struct resource *mem_res;
>         struct clk *clk;
>         int bitrate;
>         int ctrl_speed;
> @@ -310,8 +309,7 @@ static int i2c_sirfsoc_probe(struct platform_device *pdev)
>         adap = &siic->adapter;
>         adap->class = I2C_CLASS_DEPRECATED;
>
> -       mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       siic->base = devm_ioremap_resource(&pdev->dev, mem_res);
> +       siic->base = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(siic->base)) {
>                 err = PTR_ERR(siic->base);
>                 goto out;
> --
> 2.25.0
>