From: Markus Mayer <mmayer@broadcom.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Linux ARM Kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/2] memory: brcmstb_dpfe: Simplify with dev_err_probe()
Date: Fri, 28 Aug 2020 09:12:01 -0700 [thread overview]
Message-ID: <CAGt4E5s4t+O=8P=HOZo_vN3S3RgOucyaUvLy3GoOhMYCSzbG+A@mail.gmail.com> (raw)
In-Reply-To: <20200828153747.22358-1-krzk@kernel.org>
On Fri, 28 Aug 2020 at 08:37, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe(). Less code and the error value gets printed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Markus Mayer <mmayer@broadcom.com>
> ---
> drivers/memory/brcmstb_dpfe.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c
> index dcf50bb8dd69..f43ba69fbb3e 100644
> --- a/drivers/memory/brcmstb_dpfe.c
> +++ b/drivers/memory/brcmstb_dpfe.c
> @@ -901,11 +901,8 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev)
> }
>
> ret = brcmstb_dpfe_download_firmware(priv);
> - if (ret) {
> - if (ret != -EPROBE_DEFER)
> - dev_err(dev, "Couldn't download firmware -- %d\n", ret);
> - return ret;
> - }
> + if (ret)
> + return dev_err_probe(dev, ret, "Couldn't download firmware\n");
>
> ret = sysfs_create_groups(&pdev->dev.kobj, priv->dpfe_api->sysfs_attrs);
> if (!ret)
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-08-28 16:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 15:37 [PATCH 1/2] memory: brcmstb_dpfe: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-08-28 15:37 ` [PATCH 2/2] memory: tegra186-emc: " Krzysztof Kozlowski
2020-09-02 15:23 ` Krzysztof Kozlowski
2020-08-28 16:12 ` Markus Mayer [this message]
2020-08-28 17:11 ` [PATCH 1/2] memory: brcmstb_dpfe: " Florian Fainelli
2020-09-02 15:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGt4E5s4t+O=8P=HOZo_vN3S3RgOucyaUvLy3GoOhMYCSzbG+A@mail.gmail.com' \
--to=mmayer@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).