From: Mateusz Guzik <mjguzik@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: syzbot <syzbot+6ec38f7a8db3b3fb1002@syzkaller.appspotmail.com>,
almaz.alexandrovich@paragon-software.com, anton@tuxera.com,
axboe@kernel.dk, brauner@kernel.org, ebiederm@xmission.com,
keescook@chromium.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev,
syzkaller-bugs@googlegroups.com, tytso@mit.edu,
viro@zeniv.linux.org.uk, willy@infradead.org
Subject: Re: [syzbot] [ntfs3?] WARNING in do_open_execat
Date: Mon, 11 Mar 2024 20:01:14 +0100 [thread overview]
Message-ID: <CAGudoHGAzNkbgUsJwvTnmO2X5crtLfO47aaVmEMwZ=G2wWTQqA@mail.gmail.com> (raw)
In-Reply-To: <20240311184800.d7nuzahhz36rlxpg@quack3>
On 3/11/24, Jan Kara <jack@suse.cz> wrote:
> On Mon 11-03-24 11:04:04, syzbot wrote:
>> syzbot suspects this issue was fixed by commit:
>>
>> commit 6f861765464f43a71462d52026fbddfc858239a5
>> Author: Jan Kara <jack@suse.cz>
>> Date: Wed Nov 1 17:43:10 2023 +0000
>>
>> fs: Block writes to mounted block devices
>>
>> bisection log:
>> https://syzkaller.appspot.com/x/bisect.txt?x=17e3f58e180000
>> start commit: eb3479bc23fa Merge tag 'kbuild-fixes-v6.7' of
>> git://git.ke..
>> git tree: upstream
>> kernel config:
>> https://syzkaller.appspot.com/x/.config?x=bdf178b2f20f99b0
>> dashboard link:
>> https://syzkaller.appspot.com/bug?extid=6ec38f7a8db3b3fb1002
>> syz repro:
>> https://syzkaller.appspot.com/x/repro.syz?x=15073fd4e80000
>> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17b20b8f680000
>>
>> If the result looks correct, please mark the issue as fixed by replying
>> with:
>
> #syz fix: fs: Block writes to mounted block devices
>
I don't think that's correct.
The bug is ntfs instantiating an inode with bogus type (based on an
intentionally corrupted filesystem), violating the api contract with
vfs, which in turn results in the warning way later.
It may be someone sorted out ntfs doing this in the meantime, I have
not checked.
With this in mind I don't believe your patch fixed it, at best it
happened to neuter the reproducer.
vfs could definitely be patched to catch this when I_NEW is getting
cleared (only when running with debug), not in the spot which
generates the warn.
--
Mateusz Guzik <mjguzik gmail.com>
next prev parent reply other threads:[~2024-03-11 19:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 16:15 [syzbot] [ntfs?] WARNING in do_open_execat syzbot
2023-08-18 16:26 ` Eric W. Biederman
2023-08-18 17:33 ` Kees Cook
2023-08-18 17:43 ` Matthew Wilcox
2023-08-18 17:56 ` Kees Cook
2023-08-18 19:12 ` Mateusz Guzik
2023-08-19 11:34 ` Christian Brauner
2023-08-19 20:03 ` Mateusz Guzik
2023-08-19 19:16 ` Theodore Ts'o
2023-08-18 17:36 ` Mateusz Guzik
2023-08-18 20:59 ` Eric W. Biederman
2024-03-11 18:04 ` [syzbot] [ntfs3?] " syzbot
2024-03-11 18:48 ` Jan Kara
2024-03-11 19:01 ` Mateusz Guzik [this message]
2024-03-12 12:06 ` Jan Kara
2024-03-12 12:44 ` Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGudoHGAzNkbgUsJwvTnmO2X5crtLfO47aaVmEMwZ=G2wWTQqA@mail.gmail.com' \
--to=mjguzik@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=anton@tuxera.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=ntfs3@lists.linux.dev \
--cc=syzbot+6ec38f7a8db3b3fb1002@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).