From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A375BC433FE for ; Tue, 26 Oct 2021 11:18:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AC9D60232 for ; Tue, 26 Oct 2021 11:18:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235500AbhJZLVH (ORCPT ); Tue, 26 Oct 2021 07:21:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:39718 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233002AbhJZLVE (ORCPT ); Tue, 26 Oct 2021 07:21:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635247120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5d7gHBZazZOwKrch+gLmZ+IqICWgqP85pDZUly7TWn0=; b=BSOPz4+u9tVlzemHTGx8DRx+rABkDM1akUtheLNzBGP7dHTiEO9cecfooRzGne5pi9J9xI /MLKWoebunphefLzj15PN8iNmV9vfjl8zTdZd0W5pMr+ws4vmJ+vIH1BHNnDK+druCWAW6 WEWU05icEo+bkfM4OS91QbhfXf+WiXU= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-450-D-qgzdmpPumArexgKnbuUQ-1; Tue, 26 Oct 2021 07:18:39 -0400 X-MC-Unique: D-qgzdmpPumArexgKnbuUQ-1 Received: by mail-ed1-f69.google.com with SMTP id f21-20020a0564021e9500b003dd77985601so2559021edf.9 for ; Tue, 26 Oct 2021 04:18:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=5d7gHBZazZOwKrch+gLmZ+IqICWgqP85pDZUly7TWn0=; b=mXh8Uw9fMkPNlp5QZdEtlK/v4Cq/gU3VfEQ533bk61hU/YCW8hNPRTqy1m6FkyJmu6 A41VHoSmFPZN/f9o23iIDQ2NQZGySsHJCqtC+PIwAUcBiHX1p/SH2ww6NsGa3CgV9kJR kZCsXJ1Fh8wv5+h7DYcA0b7+bGwnlQ6v5XNXoV4bArApCeDCnxXnoktcr57DLDvNh0g4 osCzGKqsoq9hFTZhLDqzDlHoTjb/jEGs1LDa/3oVioXh1khxzUWC4UsFZHJB9qPDRhuz C6uR1wgpf7PENdQ9CKDobS65MGpE5MFcUnqR/8EF3ixyBdM8tV2qZNA1SNDw/JaEIIKS Oc7A== X-Gm-Message-State: AOAM531me0Qt4hl0GwsawETUHbJeg+QaH1Bo3rS30IGaTCzSY8ZVHyrM DElIRutmDhcdYH1CnsG4TiKoft2Z+swMfsYyVmrhcMN41zojXRCS9+P8LtHQyBmLFyxRf36HRrh uPeOgJTubxcT/C0JS63j9jG/G X-Received: by 2002:a17:907:94cb:: with SMTP id dn11mr10234349ejc.481.1635247118098; Tue, 26 Oct 2021 04:18:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz63YvZ/9Kc/uXShHmBdC1rnHjFeqjAByBYS0jrsmNB++hzibEdtagftjF5cyjQiQ2o8hyMCA== X-Received: by 2002:a17:907:94cb:: with SMTP id dn11mr10234329ejc.481.1635247117908; Tue, 26 Oct 2021 04:18:37 -0700 (PDT) Received: from steredhat (host-79-30-88-77.retail.telecomitalia.it. [79.30.88.77]) by smtp.gmail.com with ESMTPSA id z4sm12026897edd.46.2021.10.26.04.18.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 04:18:37 -0700 (PDT) Date: Tue, 26 Oct 2021 13:18:35 +0200 From: Stefano Garzarella To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: netdev , kernel list , "David S. Miller" , Jakub Kicinski Subject: Re: [PATCH 07/10] vsock/loopback: implement copy_peercred() Message-ID: References: <20211021123714.1125384-1-marcandre.lureau@redhat.com> <20211021123714.1125384-8-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211021123714.1125384-8-marcandre.lureau@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 21, 2021 at 04:37:11PM +0400, Marc-André Lureau wrote: >Signed-off-by: Marc-André Lureau >--- > net/vmw_vsock/vsock_loopback.c | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/net/vmw_vsock/vsock_loopback.c b/net/vmw_vsock/vsock_loopback.c >index 169a8cf65b39..59317baa4e5c 100644 >--- a/net/vmw_vsock/vsock_loopback.c >+++ b/net/vmw_vsock/vsock_loopback.c >@@ -41,6 +41,12 @@ static int vsock_loopback_send_pkt(struct virtio_vsock_pkt *pkt) > return len; > } > >+static void vsock_loopback_copy_peercred(struct sock *sk, struct virtio_vsock_pkt *pkt) >+{ >+ /* on vsock loopback, set both peers by swaping the creds */ >+ sock_swap_peercred(sk, sk_vsock(pkt->vsk)); >+} >+ It's a bit hacky set also the cred of `pkt->vsk`. I think here we should only copy the cred of the remote peer. Addind the call to t->copy_peercred() in the virtio_transport_recv_connecting() will set the other side. Thanks, Stefano